Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1857363003: [wasm] New implementation of popcnt and ctz. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] New implementation of popcnt and ctz. This patch provides a new implementation of popcnt and ctz in the case where the platform does not provide these instructions. Instead of building a TF graph which implements it we now call a C function. Additionally I turned on additional tests in test-run-wasm-64.cc R=titzer@chromium.org Committed: https://crrev.com/b4889f7d93720cebeb2c459fa8c7af0808837f2b Cr-Commit-Position: refs/heads/master@{#35685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -182 lines) Patch
M src/assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +31 lines, -159 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-external-refs.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/wasm/wasm-external-refs.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-calls-to-external-references.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 4 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 8 months ago (2016-04-06 15:09:28 UTC) #1
titzer
On 2016/04/06 15:09:28, ahaas wrote: lgtm
4 years, 8 months ago (2016-04-21 07:07:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857363003/1
4 years, 8 months ago (2016-04-21 07:20:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 07:45:45 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4889f7d93720cebeb2c459fa8c7af0808837f2b
Cr-Commit-Position: refs/heads/master@{#35685}

Powered by Google App Engine
This is Rietveld 408576698