tools/dom/scripts/generate_blink_file.py - Issue 1857343002: Fix registerElement for HTMLElement prototype should not change it's m_type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/generate_blink_file.py

Issue 1857343002: Fix registerElement for HTMLElement prototype should not change it's m_type (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix registerElement for custom elements Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/generate_blink_file.py

diff --git a/tools/dom/scripts/generate_blink_file.py b/tools/dom/scripts/generate_blink_file.py

index 2f69b0cf5c67ed0ce25fd7115e465a00e5e321ee..cdac6975c2bd9dfc4f0b94bc91611d445ca5c36a 100644

--- a/tools/dom/scripts/generate_blink_file.py

+++ b/tools/dom/scripts/generate_blink_file.py

@@ -131,6 +131,7 @@ class Blink_Utils {

// In any case, returns a typed JS wrapper compatibile with dart:html and the new

// typed JS Interop.

static defineInterceptorCustomElement(jsObject, Type type) native "Utils_defineInterceptorCustomElement";

+ static defineInterceptor(jsObject, Type type) native "Utils_defineInterceptor";

static setInstanceInterceptor(o, Type type, {bool customElement: false}) native "Utils_setInstanceInterceptor";

// This method will throw if the element isn't actually a real Element.

« no previous file with comments | « tools/deps/dartium.deps/DEPS ('k') | tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate » ('j') | no next file with comments »