Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1857343002: Fix registerElement for HTMLElement prototype should not change it's m_type (Closed)

Created:
4 years, 8 months ago by terry
Modified:
4 years, 8 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix registerElement for HTMLElement prototype should not change it's m_type TBR=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/c95b9875efd9ac904a3daaf58f2e6196fd1de2c0

Patch Set 1 #

Patch Set 2 : Fix registerElement for custom elements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-dartium.status View 2 chunks +0 lines, -9 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
terry
Committed patchset #2 (id:20001) manually as c95b9875efd9ac904a3daaf58f2e6196fd1de2c0 (presubmit successful).
4 years, 8 months ago (2016-04-05 18:59:42 UTC) #2
Jacob
4 years, 8 months ago (2016-04-05 19:52:33 UTC) #3
Message was sent while issue was closed.
lgtm

lgtm!

Powered by Google App Engine
This is Rietveld 408576698