Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1857313003: Ship --harmony-regexp-exec (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship --harmony-regexp-exec The Chrome Extensions code that was broken by this change the first time it landed has been amended to deal appropriately with the ES2015 semantics in https://codereview.chromium.org/1864733002/. BUG=v8:4602 LOG=y Committed: https://crrev.com/9bfad834d3116308dc98d3dc9f7c1845f96ab754 Cr-Commit-Position: refs/heads/master@{#35279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 8 months ago (2016-04-05 22:00:56 UTC) #2
Dan Ehrenberg
lgtm
4 years, 8 months ago (2016-04-05 22:05:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857313003/1
4 years, 8 months ago (2016-04-05 22:47:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 22:49:19 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 22:50:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bfad834d3116308dc98d3dc9f7c1845f96ab754
Cr-Commit-Position: refs/heads/master@{#35279}

Powered by Google App Engine
This is Rietveld 408576698