Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857313002: Move outRect setting to empty outside of if to avoid items not being reset (Closed)

Created:
4 years, 8 months ago by mcwilliams
Modified:
4 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move outRect setting to empty outside of if to avoid items not being reset BUG=584351 Committed: https://crrev.com/5c712f3a63cd46afa4b176d2f208e737237c9b80 Cr-Commit-Position: refs/heads/master@{#385236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mcwilliams
4 years, 8 months ago (2016-04-05 17:30:29 UTC) #2
newt (away)
lgtm, thanks!
4 years, 8 months ago (2016-04-05 17:31:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857313002/1
4 years, 8 months ago (2016-04-05 17:56:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 18:38:31 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:40:23 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5c712f3a63cd46afa4b176d2f208e737237c9b80
Cr-Commit-Position: refs/heads/master@{#385236}

Powered by Google App Engine
This is Rietveld 408576698