Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 1857273003: Allow run_instrumentation_suite to use --test-apk with a wrapper script (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Allow run_instrumentation_suite to use --test-apk with a wrapper script Downstream needs this (Chrome.apk vs ChromeBeta.apk) BUG=599919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
agrieve
On 2016/04/06 16:00:15, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org 🎮
4 years, 8 months ago (2016-04-06 16:00:28 UTC) #3
jbudorick
lgtm, I'm about to send you a similar CL for --additional-apk
4 years, 8 months ago (2016-04-06 16:01:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857273003/1
4 years, 8 months ago (2016-04-06 16:12:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3623)
4 years, 8 months ago (2016-04-06 16:18:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857273003/1
4 years, 8 months ago (2016-04-06 16:22:34 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 16:28:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299734

Powered by Google App Engine
This is Rietveld 408576698