Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 1857273002: Fix detection if a function was compiled, (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_inliner.cc
diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc
index 9ee6365a49ef934c08e2d520cb0434d7fffb6d8a..b5d2fc3ee3a0c7d3b126875bd479e6f225f333f7 100644
--- a/runtime/vm/flow_graph_inliner.cc
+++ b/runtime/vm/flow_graph_inliner.cc
@@ -637,10 +637,9 @@ class CallSiteInliner : public ValueObject {
return false;
}
- // Function has no type feedback. With precompilation we don't rely on
- // type feedback.
- if (!FLAG_precompiled_mode &&
- function.ic_data_array() == Object::null()) {
+ // Do not rely on function type feedback or presence of code to determine
+ // if a function was compiled.
+ if (!FLAG_precompiled_mode && !function.was_compiled()) {
TRACE_INLINING(THR_Print(" Bailout: not compiled yet\n"));
PRINT_INLINING_TREE("Not compiled",
&call_data->caller, &function, call_data->call);

Powered by Google App Engine
This is Rietveld 408576698