Fix detection if a function was compiled,

Fix detection if a function was compiled,

Background compilation requires that a function was run through parser in mutator thread at least once. Because snapshots can/could preload ICData and code they are not reliable signals if the function was compiled or not. Add a bit to function object.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/c87181af57b5af929519e51416cf900282e53e2e

[srdjan, 2016-04-05 18:29:59]

srdjan@google.com changed reviewers:
+ asiva@google.com, fschneider@google.com

[siva, 2016-04-05 20:20:42]

LGTM with one comment regarding reading from snapshot for precompiled case.

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1170: function.set_was_compiled(true);
Maybe clearly if you did
if (!optimized) {
  function.set_was_compiled(true);
}

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:740: func.set_was_compiled(false);
for precompiled code this should be true right?

[srdjan, 2016-04-05 20:31:19]

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1170: function.set_was_compiled(true);
On 2016/04/05 20:20:42, siva wrote:
> Maybe clearly if you did
> if (!optimized) {
>   function.set_was_compiled(true);
> }

Done.

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1857273002/diff/60001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:740: func.set_was_compiled(false);
On 2016/04/05 20:20:42, siva wrote:
> for precompiled code this should be true right?

No, was_compiled means that it was compiled in this VM instantiation. Adding
comment to getter/setter.

[srdjan, 2016-04-05 20:32:18]

Description was changed from

==========
Fix detection if a function was compiled,

Background compilation requires that a function was run through parser in
mutator thread at least once. Because snapshots can/could preload ICData and
code they are not reliable signals if the function was compiled or not. Add a
bit to function object.

BUG=
==========

to

==========
Fix detection if a function was compiled,

Background compilation requires that a function was run through parser in
mutator thread at least once. Because snapshots can/could preload ICData and
code they are not reliable signals if the function was compiled or not. Add a
bit to function object.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c87181af57b5af929519e51416cf900282e53e2e
==========

[srdjan, 2016-04-05 20:32:20]

Committed patchset #5 (id:80001) manually as
c87181af57b5af929519e51416cf900282e53e2e (presubmit successful).