Always trust internal PDF viewer.

Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box greyed out.
TEST=Install Adobe Reader X. Check you can still disable internal PDF viewer and PDFs load in Reader X.

Committed: https://crrev.com/e53608ba54b3aff711c1e1c68243417f99bcd340
Cr-Commit-Position: refs/heads/master@{#385615}

[Will Harris, 2016-04-05 17:27:36]

Description was changed from

==========
Always trust internal PDF viewer

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to drive and try to
print a sheet with embedded graph. It should show print preview successfully.
==========

to

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to drive and try to
print a sheet with embedded graph. It should show print preview successfully.
==========

[Will Harris, 2016-04-05 17:28:04]

wfh@chromium.org changed reviewers:
+ bauerb@chromium.org

[Will Harris, 2016-04-05 17:28:52]

Description was changed from

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to drive and try to
print a sheet with embedded graph. It should show print preview successfully.
==========

to

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
Check chrome://plugins shows PDF viewer "always enabled" with tick box greyed
out. Check you can still disable PDF viewer.
==========

[Will Harris, 2016-04-05 17:29:09]

Description was changed from

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
Check chrome://plugins shows PDF viewer "always enabled" with tick box greyed
out. Check you can still disable PDF viewer.
==========

to

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box
greyed out.
TEST=Check you can still disable PDF viewer.
==========

[Will Harris, 2016-04-05 17:29:34]

Description was changed from

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box
greyed out.
TEST=Check you can still disable PDF viewer.
==========

to

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box
greyed out.
TEST=Install Adobe Reader X. Check you can still disable internal PDF viewer and
PDFs load in Reader X.
==========

[Will Harris, 2016-04-05 18:07:11]

PTAL

[Peter Kasting, 2016-04-05 23:23:11]

Thank you for this!  This made PDFs annoying for power saver mode.  (We used to
have an exception for full-page plugins for click-to-play, which handled most
PDF cases, but it got removed.)

[Bernhard Bauer, 2016-04-06 08:23:46]

lgtm

https://codereview.chromium.org/1857263004/diff/1/chrome/browser/resources/pl...
File chrome/browser/resources/plugin_metadata/plugins_mac.json (right):

https://codereview.chromium.org/1857263004/diff/1/chrome/browser/resources/pl...
chrome/browser/resources/plugin_metadata/plugins_mac.json:281: "comment":
"Chrome PDF Viewer has no version information."
Nit: This should be "Google Chrome PDF viewer", no?

https://codereview.chromium.org/1857263004/diff/1/chrome/browser/resources/pl...
chrome/browser/resources/plugin_metadata/plugins_mac.json:294: "comment":
"Chrome PDF Viewer has no version information."
And should this be "Chromium PDF Viewer"?

[Bernhard Bauer, 2016-04-06 08:24:37]

Oh, also: How does Adobe Reader X work with post-NPAPI Chrome? I thought
third-party plugins were always NPAPI?

[Will Harris, 2016-04-06 17:43:25]

On 2016/04/06 08:24:37, Bernhard Bauer wrote:
> Oh, also: How does Adobe Reader X work with post-NPAPI Chrome? I thought
> third-party plugins were always NPAPI?

It just opens in the external app - there is no Reader plugin any more :)

[Will Harris, 2016-04-06 17:49:02]

Thanks for quick review. I was expecting more comments :) I still need to do a
full enterprise testing sweep with the GPO in place, so I won't commit just yet,
I'll do that today and then tick CQ.

https://codereview.chromium.org/1857263004/diff/1/chrome/browser/resources/pl...
File chrome/browser/resources/plugin_metadata/plugins_mac.json (right):

https://codereview.chromium.org/1857263004/diff/1/chrome/browser/resources/pl...
chrome/browser/resources/plugin_metadata/plugins_mac.json:281: "comment":
"Chrome PDF Viewer has no version information."
On 2016/04/06 08:23:46, Bernhard Bauer wrote:
> Nit: This should be "Google Chrome PDF viewer", no?

Done.

https://codereview.chromium.org/1857263004/diff/1/chrome/browser/resources/pl...
chrome/browser/resources/plugin_metadata/plugins_mac.json:294: "comment":
"Chrome PDF Viewer has no version information."
On 2016/04/06 08:23:46, Bernhard Bauer wrote:
> And should this be "Chromium PDF Viewer"?

Done.

[Will Harris, 2016-04-06 21:46:41]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-04-06 21:46:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1857263004/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-04-06 21:47:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857263004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857263004/20001

[commit-bot: I haz the power, 2016-04-06 21:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 21:51:29]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Will Harris, 2016-04-06 22:29:11]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-04-06 22:29:11]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1857263004/#ps40001
(title: "rebase rebase")

[commit-bot: I haz the power, 2016-04-06 22:29:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857263004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857263004/40001

[commit-bot: I haz the power, 2016-04-06 23:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:39:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Will Harris, 2016-04-06 23:41:10]

On 2016/04/06 23:39:09, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[19129:19129:0406/163029:FATAL:surface_aggregator.cc(321)] Check failed:
inverse_valid.

in cc::CalculateQuadSpaceDamageRect which looks like an unrelated flake.

[Will Harris, 2016-04-06 23:41:14]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:42:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857263004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857263004/40001

[commit-bot: I haz the power, 2016-04-07 02:19:10]

Description was changed from

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box
greyed out.
TEST=Install Adobe Reader X. Check you can still disable internal PDF viewer and
PDFs load in Reader X.
==========

to

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box
greyed out.
TEST=Install Adobe Reader X. Check you can still disable internal PDF viewer and
PDFs load in Reader X.
==========

[commit-bot: I haz the power, 2016-04-07 02:19:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 02:20:47]

Description was changed from

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box
greyed out.
TEST=Install Adobe Reader X. Check you can still disable internal PDF viewer and
PDFs load in Reader X.
==========

to

==========
Always trust internal PDF viewer.

Internal PDF viewer will always load if it is not disabled, even if
plugins are set to CONTENT_SETTING_BLOCK in content settings.

BUG=509251
TEST=Block all plugins in chrome://settings/content, go to Google Drive and try
to print a sheet with embedded graph. It should show print preview successfully.
TEST=Check chrome://plugins shows PDF viewer "always enabled" with tick box
greyed out.
TEST=Install Adobe Reader X. Check you can still disable internal PDF viewer and
PDFs load in Reader X.

Committed: https://crrev.com/e53608ba54b3aff711c1e1c68243417f99bcd340
Cr-Commit-Position: refs/heads/master@{#385615}
==========

[commit-bot: I haz the power, 2016-04-07 02:20:49]

Patchset 3 (id:??) landed as
https://crrev.com/e53608ba54b3aff711c1e1c68243417f99bcd340
Cr-Commit-Position: refs/heads/master@{#385615}

[tim5, 2016-06-22 18:40:31]

On 2016/04/05 23:23:11, Peter Kasting wrote:
> Thank you for this!  This made PDFs annoying for power saver mode.  (We used
to
> have an exception for full-page plugins for click-to-play, which handled most
> PDF cases, but it got removed.)

Can someone explain why this was done? I am not allowed to view the original
bug. I don't have permission. 

Please see the post here for why some of us think this change was a very bad
move: 
https://productforums.google.com/forum/#!topic/chrome/rE-nZIfmDrU;context-pla...

Mainly, Chromium and Chrome already had a major vulnerability in the PDF viewer.
So now you have made it so that we have no choice but to either not use the
viewer or ALWAYS allow it? You open us up to attackers using potential future
vulnerabilities. Why?