Scan-out capable buffers (aka ui::NativePixmap) for Mus

Scan-out capable buffers (aka ui::NativePixmap) for Mus

To run on a ChromeBook, Mus needs to support allocation of buffers
that can be used for scanout. This patch extends Mus's GPU
infrastructure to allocate scannable images.

BUG=596549
Committed: https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40
Cr-Commit-Position: refs/heads/master@{#386164}

[rjkroege, 2016-04-06 21:54:06]

rjkroege@chromium.org changed reviewers:
+ fsamuel@chromium.org

[rjkroege, 2016-04-06 21:54:07]

PTAL. I know it needs to be rebased but you can start reviewing pending your
patch landing if you like.

[Fady Samuel, 2016-04-06 22:02:02]

lgtm modulo a few comments.

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/BUILD.gn
File components/mus/gles2/BUILD.gn (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/BUILD....
components/mus/gles2/BUILD.gn:81: "ozone_gpu_memory_buffer.h",
move this to an if (use_ozone) block?

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
File components/mus/gles2/command_buffer_driver.cc (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
components/mus/gles2/command_buffer_driver.cc:96: if (!underlying_surface) {
nit: unnecessary braces.

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
File components/mus/gles2/command_buffer_local.cc (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
components/mus/gles2/command_buffer_local.cc:242:
base::SharedMemory::DuplicateHandle(handle.handle);
I don't think we need this. Please add a TODO to verify?

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/ozone_...
File components/mus/gles2/ozone_gpu_memory_buffer.cc (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/ozone_...
components/mus/gles2/ozone_gpu_memory_buffer.cc:76: return mapped_;
nit: return true is a bit more readable?

[rjkroege, 2016-04-06 22:45:45]

comments addressed.

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/BUILD.gn
File components/mus/gles2/BUILD.gn (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/BUILD....
components/mus/gles2/BUILD.gn:81: "ozone_gpu_memory_buffer.h",
On 2016/04/06 22:02:02, Fady Samuel wrote:
> move this to an if (use_ozone) block?

Done.

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
File components/mus/gles2/command_buffer_driver.cc (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
components/mus/gles2/command_buffer_driver.cc:96: if (!underlying_surface) {
On 2016/04/06 22:02:02, Fady Samuel wrote:
> nit: unnecessary braces.

Done.

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
File components/mus/gles2/command_buffer_local.cc (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/comman...
components/mus/gles2/command_buffer_local.cc:242:
base::SharedMemory::DuplicateHandle(handle.handle);
On 2016/04/06 22:02:02, Fady Samuel wrote:
> I don't think we need this. Please add a TODO to verify?

Done.

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/ozone_...
File components/mus/gles2/ozone_gpu_memory_buffer.cc (right):

https://codereview.chromium.org/1857243005/diff/1/components/mus/gles2/ozone_...
components/mus/gles2/ozone_gpu_memory_buffer.cc:76: return mapped_;
On 2016/04/06 22:02:02, Fady Samuel wrote:
> nit: return true is a bit more readable?

I'll ignore this one.

[rjkroege, 2016-04-06 22:45:49]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-04-06 22:45:49]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1857243005/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-04-06 22:46:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857243005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857243005/20001

[commit-bot: I haz the power, 2016-04-06 23:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:05:18]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rjkroege, 2016-04-07 20:41:26]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-04-07 20:41:26]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1857243005/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-04-07 20:42:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857243005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857243005/60001

[commit-bot: I haz the power, 2016-04-07 22:04:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 22:04:47]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[rjkroege, 2016-04-08 18:52:03]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-04-08 18:52:03]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1857243005/#ps80001
(title: "build fix for windows")

[commit-bot: I haz the power, 2016-04-08 18:52:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857243005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857243005/80001

[commit-bot: I haz the power, 2016-04-08 19:51:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-08 19:53:03]

Description was changed from

==========
Scan-out capable buffers (aka ui::NativePixmap) for Mus

To run on a ChromeBook, Mus needs to support allocation of buffers
that can be used for scanout. This patch extends Mus's GPU
infrastructure to allocate scannable images.

BUG=596549
==========

to

==========
Scan-out capable buffers (aka ui::NativePixmap) for Mus

To run on a ChromeBook, Mus needs to support allocation of buffers
that can be used for scanout. This patch extends Mus's GPU
infrastructure to allocate scannable images.

BUG=596549

Committed: https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40
Cr-Commit-Position: refs/heads/master@{#386164}
==========

[commit-bot: I haz the power, 2016-04-08 19:53:04]

Patchset 5 (id:??) landed as
https://crrev.com/f70fe98e9f2c0dbdeabe5c297f1d930347e87b40
Cr-Commit-Position: refs/heads/master@{#386164}