Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1857233002: Revert of Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GL… (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GL… (patchset #3 id:40001 of https://codereview.chromium.org/1853103003/ ) Reason for revert: causing crashes on win8 bot? Original issue's description: > Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003 > > Committed: https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89 TBR=egdaniel@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/3b597388b35967a751fb055d0b8fcc30b443b5a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -424 lines) Patch
M tests/TestConfigParsing.cpp View 5 chunks +3 lines, -28 lines 0 comments Download
M tools/dm_flags.json View 1 chunk +0 lines, -308 lines 0 comments Download
M tools/dm_flags.py View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 3 chunks +3 lines, -13 lines 0 comments Download
M tools/nanobench_flags.json View 8 chunks +8 lines, -59 lines 0 comments Download
M tools/nanobench_flags.py View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bsalomon
4 years, 8 months ago (2016-04-05 14:26:12 UTC) #1
Created Revert of Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb
that explictly use OpenGL rather than GL…

Powered by Google App Engine
This is Rietveld 408576698