Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: Source/core/css/CSSCursorImageValue.h

Issue 185723006: Oilpan: Workaround for crash on quora and geek-and-poke. There is a finalization issue that we need… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix comment. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSCursorImageValue.h
diff --git a/Source/core/css/CSSCursorImageValue.h b/Source/core/css/CSSCursorImageValue.h
index a94ea2bd4dff3d5dc3a1f442c8859ecc4646d6de..9e42d62ed3a8a886615fd1931eb8e85e3f3c3fc9 100644
--- a/Source/core/css/CSSCursorImageValue.h
+++ b/Source/core/css/CSSCursorImageValue.h
@@ -67,7 +67,11 @@ private:
String cachedImageURL();
void clearImageResource();
- RefPtrWillBeMember<CSSValue> m_imageValue;
+ // FIXME: oilpan: This should be a Member but we need to resolve
+ // finalization order issues first. The CSSCursorImageValue
+ // destructor uses m_imageValue. Leaving it as a RefPtr as a
+ // workaround for now.
+ RefPtr<CSSValue> m_imageValue;
bool m_hasHotSpot;
IntPoint m_hotSpot;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698