LayoutTests/fast/css/bfc-percentage-margin-expected.html - Issue 185723005: Use correct container width as base for percentage margins.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/bfc-percentage-margin-expected.html

Issue 185723005: Use correct container width as base for percentage margins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .square {

	4 width: 100px;

	5 height: 100px;

	6 background-color: blue;

	7 position: absolute;

	8 }

	9 .right {

	10 left: 128px;

	11 }

	12 </style>

	13 <p>You should see two blue squares below.</p>

	14 <div class="square"></div>

	15 <div class="square right"></div>
	Julien - ping for review 2014/03/06 23:05:05 It's weird that the offset is 128px when the left- It's weird that the offset is 128px when the left-most square is not even offset by 8px (I assume this is due to the body's margin). rune 2014/03/07 14:20:24 Yes, I've modified the reference html now to add a Show quoted text On 2014/03/06 23:05:05, Julien Chaffraix - PST wrote: > It's weird that the offset is 128px when the left-most square is not even offset > by 8px (I assume this is due to the body's margin). Yes, I've modified the reference html now to add a relative container to be able to use 120px for left instead.
OLD	NEW

« no previous file with comments | « LayoutTests/fast/css/bfc-percentage-margin.html ('k') | Source/core/rendering/RenderBox.h » ('j') | Source/core/rendering/RenderBox.cpp » ('J')