Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1857223002: [Custom Tabs] Make ClientManagerTest derive from NativeLibraryTestBase. (Closed)

Created:
4 years, 8 months ago by Bernhard Bauer
Modified:
4 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Custom Tabs] Make ClientManagerTest derive from NativeLibraryTestBase. This takes care of everything that needs to happen to use the native library (like initializing PathUtils). BUG=600702 Committed: https://crrev.com/25f9d3d669d28fe48444a5dd4314d2a0148c68e7 Cr-Commit-Position: refs/heads/master@{#386028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bernhard Bauer
Sorry, forgot to send this out during my sheriff shift on Tue. Please review, thanks!
4 years, 8 months ago (2016-04-07 16:22:17 UTC) #2
Benoit L
On 2016/04/07 16:22:17, Bernhard Bauer wrote: > Sorry, forgot to send this out during my ...
4 years, 8 months ago (2016-04-08 08:38:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857223002/1
4 years, 8 months ago (2016-04-08 09:07:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 09:39:16 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 09:40:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25f9d3d669d28fe48444a5dd4314d2a0148c68e7
Cr-Commit-Position: refs/heads/master@{#386028}

Powered by Google App Engine
This is Rietveld 408576698