MIPS: Add tests for AddBranchOvf and SubBranchOvf macro instructions.

MIPS: Add tests for AddBranchOvf and SubBranchOvf macro instructions.

BUG=

Committed: https://crrev.com/d4403b172f357e6e44e4571a3332c437d3ce08c9
Cr-Commit-Position: refs/heads/master@{#35320}

[ivica.bogosavljevic, 2016-04-05 12:46:11]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ balazs.kilvady@imgtec.com, ilija.pavlovic@imgtec.com, marija.antic@imgtec.com,
miran.karic@imgtec.com

[ivica.bogosavljevic, 2016-04-05 12:46:12]

PTAL

[balazs.kilvady, 2016-04-05 17:25:20]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@mattakis.com

[balazs.kilvady, 2016-04-05 17:25:21]

Looks good. I added a few nits.

https://codereview.chromium.org/1857193002/diff/1/test/cctest/test-macro-asse...
File test/cctest/test-macro-assembler-mips.cc (right):

https://codereview.chromium.org/1857193002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:424: 
Instead of the above macro-magic I would prefer a template/lambda based
solution, for example:

template <typename T, typename Func>
static void ForInputs(const std::vector<T>& inputs, Func func) {
  for (auto it = inputs.begin(); it != inputs.end(); ++it) {
    func(*it);
  }
}

TEST(Cvt_s_uw_Trunc_uw_s) {
  CcTest::InitializeVM();
  ForInputs(uint32_test_values(), [](uint32_t input) {
    CHECK_EQ(static_cast<float>(input),
             run_Cvt<uint64_t>(input, [](MacroAssembler* masm) {
      __ Cvt_s_uw(f0, a0);
      __ mthc1(zero_reg, f2);
      __ Trunc_uw_s(f2, f0, f1);
    }));
  });
}

For me it is more readable and looks to be more maintainable. But it is up to
you if you like it or not :)

https://codereview.chromium.org/1857193002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:533: Func GenerateOverflowInstructions)
{
Functionname should be run_overflow or RunOverflow, I think. And it could be
static.

https://codereview.chromium.org/1857193002/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips.cc:557: return static_cast<bool>(r);
Could be simply 'return r;' or 'return r != 0;'

[balazs.kilvady, 2016-04-06 15:06:33]

lgtm

[ivica.bogosavljevic, 2016-04-07 06:46:03]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 06:46:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857193002/20001

[commit-bot: I haz the power, 2016-04-07 07:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 07:08:10]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2016-04-07 07:13:28]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[commit-bot: I haz the power, 2016-04-07 07:13:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857193002/20001

[commit-bot: I haz the power, 2016-04-07 07:15:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 07:16:40]

Description was changed from

==========
MIPS: Add tests for AddBranchOvf and SubBranchOvf macro instructions.

BUG=
==========

to

==========
MIPS: Add tests for AddBranchOvf and SubBranchOvf macro instructions.

BUG=

Committed: https://crrev.com/d4403b172f357e6e44e4571a3332c437d3ce08c9
Cr-Commit-Position: refs/heads/master@{#35320}
==========

[commit-bot: I haz the power, 2016-04-07 07:16:41]

Patchset 2 (id:??) landed as
https://crrev.com/d4403b172f357e6e44e4571a3332c437d3ce08c9
Cr-Commit-Position: refs/heads/master@{#35320}