[Telemetry] Add action_runner property to Tab

[Telemetry] Add action_runner property to Tab

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f7e16d521d6b9ea8b47709a1426f02150da196d8

[perezju, 2016-04-05 11:40:21]

perezju@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2016-04-05 13:12:27]

On 2016/04/05 11:40:21, perezju wrote:

What is the cycle?

[perezju, 2016-04-06 12:49:21]

On 2016/04/05 13:12:27, nednguyen wrote:
> On 2016/04/05 11:40:21, perezju wrote:
> 
> What is the cycle?

telemetry.internal.browser.tab
-> telemetry.page [implicit to import telemetry.page.action_runner]
-> telemetry.page.shared_page_state
-> telemetry.internal.browser.browser_finder
-> telemetry.internal.backends.chrome.android_browser_finder
-> telemetry.internal.backends.chrome.android_browser_backend
-> telemetry.internal.backends.chrome.chrome_browser_backend
-> telemetry.internal.backends.chrome.tab_list_backend
-> telemetry.internal.browser.tab

I've also found this quite hard to debug. Just trying to run a benchmark fails
with other unrelated messages (claims that some page sets are missing, when they
are not, I guess this error messes up the page set discovery mechanism somehow).

[nednguyen, 2016-04-06 14:35:37]

On 2016/04/06 12:50:02, perezju wrote:

lgtm

Thanks for the info, Juan. We will work on resolving this cyclic dep, feel free
to land this.

[nednguyen, 2016-04-06 14:55:49]

https://codereview.chromium.org/1857173002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/browser/tab.py (right):

https://codereview.chromium.org/1857173002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/browser/tab.py:36: from telemetry.page import
action_runner
Ah, seems like the bug here is action_runner module lives in page package.

[perezju, 2016-04-07 08:26:21]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-04-07 08:26:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857173002/1

[commit-bot: I haz the power, 2016-04-07 08:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 08:29:41]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[perezju, 2016-04-07 09:51:06]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-04-07 09:51:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857173002/1

[commit-bot: I haz the power, 2016-04-07 09:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 09:54:04]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[nednguyen(REVIEW IN OTHER ACC), 2016-04-07 12:22:12]

nednguyen@chromium.org changed reviewers:
+ aiolos@chromium.org, nednguyen@chromium.org

[nednguyen(REVIEW IN OTHER ACC), 2016-04-07 12:22:12]

+Kari: dev_server is having problems again :(

[nednguyen, 2016-04-07 15:20:35]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-04-07 15:20:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857173002/1

[commit-bot: I haz the power, 2016-04-07 15:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 15:23:37]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[perezju, 2016-04-08 09:00:31]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-04-08 09:00:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857173002/1

[commit-bot: I haz the power, 2016-04-08 09:31:19]

Description was changed from

==========
[Telemetry] Add action_runner property to Tab
==========

to

==========
[Telemetry] Add action_runner property to Tab

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-04-08 09:31:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...