Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1857163002:
[elements] cleaning up string wrapper elements kind and adding tests (Closed)
|
Created:
4 years, 8 months ago by Camillo Bruni Modified:
4 years, 8 months ago Reviewers:
Jakob Kummerow CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[elements] cleaning up string wrapper elements kind and adding tests
drive-by-fix: unify template parameters
BUG=chromium:586068
LOG=n
Committed: https://crrev.com/ca5b896fab0556d821b516db075194dff8fcfa36
Cr-Commit-Position: refs/heads/master@{#35302}
Patch Set 1 #Patch Set 2 : avoid another place of using STRING_WRAPPER_ELEMENTS_KIND #Patch Set 3 : cleanup #
Messages
Total messages: 23 (12 generated)
Description was changed from ========== [elements] cleaning up string wrapper elements kind and adding tests BUG=chromium:586068 ========== to ========== [elements] cleaning up string wrapper elements kind and adding tests The string wrapper elements kind should work similar to sloppy arguments to avoid accidentally missing out on the write barriers. BUG=chromium:586068 ==========
Description was changed from ========== [elements] cleaning up string wrapper elements kind and adding tests The string wrapper elements kind should work similar to sloppy arguments to avoid accidentally missing out on the write barriers. BUG=chromium:586068 ========== to ========== [elements] cleaning up string wrapper elements kind and adding tests BUG=chromium:586068 ==========
cbruni@chromium.org changed reviewers: + jkummerow@chromium.org
PTAL cleanup up some code which makes it a bit easier to compare against SLOPPY_ARGUMENTS
Description was changed from ========== [elements] cleaning up string wrapper elements kind and adding tests BUG=chromium:586068 ========== to ========== [elements] cleaning up string wrapper elements kind and adding tests BUG=chromium:586068 ==========
lgtm
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857163002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13209)
Description was changed from ========== [elements] cleaning up string wrapper elements kind and adding tests BUG=chromium:586068 ========== to ========== [elements] cleaning up string wrapper elements kind and adding tests BUG=chromium:586068 LOG=n ==========
Description was changed from ========== [elements] cleaning up string wrapper elements kind and adding tests BUG=chromium:586068 LOG=n ========== to ========== [elements] cleaning up string wrapper elements kind and adding tests drive-by-fix: unify template parameters BUG=chromium:586068 LOG=n ==========
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857163002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL again, did some additional cleanup.
patch set 3 LGTM.
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857163002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [elements] cleaning up string wrapper elements kind and adding tests drive-by-fix: unify template parameters BUG=chromium:586068 LOG=n ========== to ========== [elements] cleaning up string wrapper elements kind and adding tests drive-by-fix: unify template parameters BUG=chromium:586068 LOG=n Committed: https://crrev.com/ca5b896fab0556d821b516db075194dff8fcfa36 Cr-Commit-Position: refs/heads/master@{#35302} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ca5b896fab0556d821b516db075194dff8fcfa36 Cr-Commit-Position: refs/heads/master@{#35302} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
