Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857143002: Oilpan: Remove RefCountedGarbageCollectedEventTargetWithInlineData (Closed)

Created:
4 years, 8 months ago by haraken
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, sof, tasak
CC:
chromium-reviews, shans, tzik, mlamouri+watch-screen-orientation_chromium.org, eae+blinkwatch, fs, eric.carlson_apple.com, scheib+watch_chromium.org, apavlov+blink_chromium.org, jkarlin+watch_chromium.org, kinuko+worker_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, jsbell+idb_chromium.org, toyoshim+midi_chromium.org, yhirano+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, Eric Willigers, kenneth.christiansen, nessy, rjwright, Peter Beverloo, sof, nhiroki, Raymond Toy, loading-reviews_chromium.org, tommyw+watchlist_chromium.org, timvolodine, darktears, Nate Chapin, vcarbune.chromium, philipj_slow, michaeln, tyoshino+watch_chromium.org, dtapuska+blinkwatch_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, serviceworker-reviews, gasubic, falken, blink-reviews-events_chromium.org, ortuno+watch_chromium.org, kinuko+serviceworker, cmumford, horo+watch_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Remove RefCountedGarbageCollectedEventTargetWithInlineData Now that Oilpan was shipped, we no longer need the indireciton of RefCountedGarbageCollectedEventTargetWithInlineData. EventTarget classes can just directly inherit from EventTargetWithInlineData. BUG=585328 Committed: https://crrev.com/e4e171d6cb0eff52c5832bd1577a08b800cdf812 Cr-Commit-Position: refs/heads/master@{#386373}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Total comments: 3

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -136 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.h View 1 2 3 4 5 3 chunks +5 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCue.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCue.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackListBase.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCache.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/AbstractWorker.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/AbstractWorker.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestEventTarget.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBufferList.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBufferList.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionStatus.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationAvailability.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationReceiver.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackAvailability.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognition.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIPort.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 39 (17 generated)
haraken
PTAL
4 years, 8 months ago (2016-04-05 07:47:27 UTC) #2
sof
lgtm https://codereview.chromium.org/1857143002/diff/20001/third_party/WebKit/Source/core/events/EventTarget.h File third_party/WebKit/Source/core/events/EventTarget.h (left): https://codereview.chromium.org/1857143002/diff/20001/third_party/WebKit/Source/core/events/EventTarget.h#oldcode88 third_party/WebKit/Source/core/events/EventTarget.h:88: // RefCountedGarbageCollected<YourClass> in addition to EventTargetWithInlineData, Could you ...
4 years, 8 months ago (2016-04-05 07:52:13 UTC) #3
haraken
> https://codereview.chromium.org/1857143002/diff/20001/third_party/WebKit/Source/core/events/EventTarget.h > File third_party/WebKit/Source/core/events/EventTarget.h (left): > > https://codereview.chromium.org/1857143002/diff/20001/third_party/WebKit/Source/core/events/EventTarget.h#oldcode88 > third_party/WebKit/Source/core/events/EventTarget.h:88: // > RefCountedGarbageCollected<YourClass> in ...
4 years, 8 months ago (2016-04-05 07:57:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857143002/40001
4 years, 8 months ago (2016-04-05 07:58:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/169376)
4 years, 8 months ago (2016-04-05 09:19:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857143002/40001
4 years, 8 months ago (2016-04-05 09:37:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/169391)
4 years, 8 months ago (2016-04-05 11:06:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857143002/40001
4 years, 8 months ago (2016-04-05 11:16:47 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/169421)
4 years, 8 months ago (2016-04-05 13:06:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857143002/40001
4 years, 8 months ago (2016-04-05 14:04:54 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/169491)
4 years, 8 months ago (2016-04-05 15:20:44 UTC) #21
haraken
+tasak I think I'm hitting a win-only link error related to template<T> + CORE_EXPORT. I ...
4 years, 8 months ago (2016-04-05 23:53:02 UTC) #23
haraken
https://codereview.chromium.org/1857143002/diff/40001/third_party/WebKit/Source/core/events/EventTarget.h File third_party/WebKit/Source/core/events/EventTarget.h (right): https://codereview.chromium.org/1857143002/diff/40001/third_party/WebKit/Source/core/events/EventTarget.h#newcode197 third_party/WebKit/Source/core/events/EventTarget.h:197: class GC_PLUGIN_IGNORE("513199") CORE_EXPORT EventTargetWithInlineData : public EventTarget { tasak@ ...
4 years, 8 months ago (2016-04-06 11:23:57 UTC) #24
haraken
Now this CL is ready to land. PTAL.
4 years, 8 months ago (2016-04-11 08:30:34 UTC) #25
haraken
https://codereview.chromium.org/1857143002/diff/80001/third_party/WebKit/Source/core/events/EventTarget.h File third_party/WebKit/Source/core/events/EventTarget.h (right): https://codereview.chromium.org/1857143002/diff/80001/third_party/WebKit/Source/core/events/EventTarget.h#newcode110 third_party/WebKit/Source/core/events/EventTarget.h:110: // a pre-finalizer instead. Note: This fact is checked ...
4 years, 8 months ago (2016-04-11 08:32:20 UTC) #26
sof
lgtm https://codereview.chromium.org/1857143002/diff/80001/third_party/WebKit/Source/core/events/EventTarget.h File third_party/WebKit/Source/core/events/EventTarget.h (right): https://codereview.chromium.org/1857143002/diff/80001/third_party/WebKit/Source/core/events/EventTarget.h#newcode89 third_party/WebKit/Source/core/events/EventTarget.h:89: // EventTargetWithInlineData) must come first in remove "(or ...
4 years, 8 months ago (2016-04-11 10:43:46 UTC) #27
haraken
> https://codereview.chromium.org/1857143002/diff/80001/third_party/WebKit/Source/core/events/EventTarget.h > File third_party/WebKit/Source/core/events/EventTarget.h (right): > > https://codereview.chromium.org/1857143002/diff/80001/third_party/WebKit/Source/core/events/EventTarget.h#newcode89 > third_party/WebKit/Source/core/events/EventTarget.h:89: // > EventTargetWithInlineData) must ...
4 years, 8 months ago (2016-04-11 11:07:25 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857143002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857143002/100001
4 years, 8 months ago (2016-04-11 11:07:47 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/157349) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-11 11:10:51 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857143002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857143002/120001
4 years, 8 months ago (2016-04-11 11:15:55 UTC) #36
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-11 12:47:00 UTC) #37
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 12:48:30 UTC) #39
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/e4e171d6cb0eff52c5832bd1577a08b800cdf812
Cr-Commit-Position: refs/heads/master@{#386373}

Powered by Google App Engine
This is Rietveld 408576698