Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: Source/devtools/front_end/ConsoleView.js

Issue 185713007: DevTools: Add timestamp support in the console (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ConsoleModel.js ('k') | Source/devtools/front_end/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ConsoleView.js
diff --git a/Source/devtools/front_end/ConsoleView.js b/Source/devtools/front_end/ConsoleView.js
index bcfc64da5f850d1779798f1ac18171ec5744eec7..c343566bad97167dadf72a88eb601e4a54356826 100644
--- a/Source/devtools/front_end/ConsoleView.js
+++ b/Source/devtools/front_end/ConsoleView.js
@@ -103,7 +103,6 @@ WebInspector.ConsoleView = function(hideContextSelector)
this._messageToViewMessage = new Map();
/** @type {!Array.<!WebInspector.ConsoleMessage>} */
this._consoleMessages = [];
- this._previousMessage = null;
this.prompt = new WebInspector.TextPromptWithHistory(this._completionsForTextPrompt.bind(this));
this.prompt.setSuggestBoxEnabled("generic-suggest");
@@ -421,13 +420,14 @@ WebInspector.ConsoleView.prototype = {
else
this._urlToMessageCount[message.url] = 1;
- if (this._previousMessage && !message.isGroupMessage() && message.isEqual(this._previousMessage)) {
- this._messageToViewMessage.get(this._previousMessage).incrementRepeatCount();
+ var previousMessage = this._consoleMessages.peekLast();
+ if (previousMessage && !message.isGroupMessage() && message.isEqual(previousMessage)) {
+ previousMessage.timestamp = message.timestamp;
+ this._messageToViewMessage.get(previousMessage).incrementRepeatCount();
return;
}
this._consoleMessages.push(message);
- this._previousMessage = message;
var viewMessage = this._createViewMessage(target, message);
if (this._filter.shouldBeVisible(viewMessage))
@@ -507,7 +507,6 @@ WebInspector.ConsoleView.prototype = {
this._visibleViewMessages = [];
this._searchResults = [];
- this._previousMessage = null;
this._messageToViewMessage.clear();
this._consoleMessages = [];
« no previous file with comments | « Source/devtools/front_end/ConsoleModel.js ('k') | Source/devtools/front_end/ConsoleViewMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698