Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: Source/core/inspector/InspectorConsoleAgent.cpp

Issue 185713007: DevTools: Add timestamp support in the console (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed apavlov's comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorConsoleAgent.cpp
diff --git a/Source/core/inspector/InspectorConsoleAgent.cpp b/Source/core/inspector/InspectorConsoleAgent.cpp
index f5316b043718644a4e3844f75dfe942af5b8252b..680bf59a192a48f9da4d91626f20cdb4a015ae45 100644
--- a/Source/core/inspector/InspectorConsoleAgent.cpp
+++ b/Source/core/inspector/InspectorConsoleAgent.cpp
@@ -67,7 +67,6 @@ InspectorConsoleAgent::InspectorConsoleAgent(InspectorTimelineAgent* timelineAge
, m_timelineAgent(timelineAgent)
, m_injectedScriptManager(injectedScriptManager)
, m_frontend(0)
- , m_previousMessage(0)
, m_expiredConsoleMessageCount(0)
, m_enabled(false)
{
@@ -122,7 +121,6 @@ void InspectorConsoleAgent::clearMessages(ErrorString*)
{
m_consoleMessages.clear();
m_expiredConsoleMessageCount = 0;
- m_previousMessage = 0;
m_injectedScriptManager->releaseObjectGroup("console");
if (m_frontend && m_enabled)
m_frontend->messagesCleared();
@@ -302,27 +300,15 @@ void InspectorConsoleAgent::setMonitoringXHREnabled(ErrorString*, bool enabled)
m_state->setBoolean(ConsoleAgentState::monitoringXHR, enabled);
}
-static bool isGroupMessage(MessageType type)
-{
- return type == StartGroupMessageType
- || type == StartGroupCollapsedMessageType
- || type == EndGroupMessageType;
-}
void InspectorConsoleAgent::addConsoleMessage(PassOwnPtr<ConsoleMessage> consoleMessage)
{
ASSERT_ARG(consoleMessage, consoleMessage);
- if (m_previousMessage && !isGroupMessage(m_previousMessage->type()) && m_previousMessage->isEqual(consoleMessage.get())) {
- m_previousMessage->incrementCount();
- if (m_frontend && m_enabled)
- m_previousMessage->updateRepeatCountInConsole(m_frontend);
- } else {
- m_previousMessage = consoleMessage.get();
- m_consoleMessages.append(consoleMessage);
- if (m_frontend && m_enabled)
- m_previousMessage->addToFrontend(m_frontend, m_injectedScriptManager, true);
- }
+ ConsoleMessage* msg = consoleMessage.get();
apavlov 2014/03/21 14:47:58 Blink style does not honor abbreviations. Moreover
+ m_consoleMessages.append(consoleMessage);
+ if (m_frontend && m_enabled)
+ msg->addToFrontend(m_frontend, m_injectedScriptManager, true);
if (!m_frontend && m_consoleMessages.size() >= maximumConsoleMessages) {
m_expiredConsoleMessageCount += expireConsoleMessagesStep;

Powered by Google App Engine
This is Rietveld 408576698