Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: Source/core/inspector/ConsoleMessage.cpp

Issue 185713007: DevTools: Add timestamp support in the console (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Up for review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/ConsoleMessage.cpp
diff --git a/Source/core/inspector/ConsoleMessage.cpp b/Source/core/inspector/ConsoleMessage.cpp
index 4c33b189731841be898fddba2b9e1d3bfb0007cd..17b80861e289844cdb3164fc6d25d8d353780204 100644
--- a/Source/core/inspector/ConsoleMessage.cpp
+++ b/Source/core/inspector/ConsoleMessage.cpp
@@ -53,7 +53,6 @@ ConsoleMessage::ConsoleMessage(bool canGenerateCallStack, MessageSource source,
, m_url()
, m_line(0)
, m_column(0)
- , m_repeatCount(1)
, m_requestId(IdentifiersFactory::requestId(0))
, m_timestamp(WTF::currentTime())
{
@@ -68,7 +67,6 @@ ConsoleMessage::ConsoleMessage(bool canGenerateCallStack, MessageSource source,
, m_url(url)
, m_line(line)
, m_column(column)
- , m_repeatCount(1)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
, m_timestamp(WTF::currentTime())
{
@@ -83,7 +81,6 @@ ConsoleMessage::ConsoleMessage(bool, MessageSource source, MessageType type, Mes
, m_arguments(nullptr)
, m_line(0)
, m_column(0)
- , m_repeatCount(1)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
, m_timestamp(WTF::currentTime())
{
@@ -105,7 +102,6 @@ ConsoleMessage::ConsoleMessage(bool canGenerateCallStack, MessageSource source,
, m_url()
, m_line(0)
, m_column(0)
- , m_repeatCount(1)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
, m_timestamp(WTF::currentTime())
{
@@ -198,7 +194,6 @@ void ConsoleMessage::addToFrontend(InspectorFrontend::Console* frontend, Injecte
jsonObj->setLine(static_cast<int>(m_line));
jsonObj->setColumn(static_cast<int>(m_column));
jsonObj->setUrl(m_url);
- jsonObj->setRepeatCount(static_cast<int>(m_repeatCount));
if (m_source == NetworkMessageSource && !m_requestId.isEmpty())
jsonObj->setNetworkRequestId(m_requestId);
if (m_arguments && m_arguments->argumentCount()) {
@@ -232,46 +227,6 @@ void ConsoleMessage::addToFrontend(InspectorFrontend::Console* frontend, Injecte
frontend->messageAdded(jsonObj);
}
-void ConsoleMessage::incrementCount()
-{
- m_timestamp = WTF::currentTime();
- ++m_repeatCount;
-}
-
-void ConsoleMessage::updateRepeatCountInConsole(InspectorFrontend::Console* frontend)
-{
- frontend->messageRepeatCountUpdated(m_repeatCount, m_timestamp);
-}
-
-bool ConsoleMessage::isEqual(ConsoleMessage* msg) const
-{
- if (m_arguments) {
- if (!m_arguments->isEqual(msg->m_arguments.get()))
- return false;
- // Never treat objects as equal - their properties might change over time.
- for (size_t i = 0; i < m_arguments->argumentCount(); ++i) {
- if (m_arguments->argumentAt(i).isObject())
- return false;
- }
- } else if (msg->m_arguments)
- return false;
-
- if (m_callStack) {
- if (!m_callStack->isEqual(msg->m_callStack.get()))
- return false;
- } else if (msg->m_callStack)
- return false;
-
- return msg->m_source == m_source
- && msg->m_type == m_type
- && msg->m_level == m_level
- && msg->m_message == m_message
- && msg->m_line == m_line
- && msg->m_column == m_column
- && msg->m_url == m_url
- && msg->m_requestId == m_requestId;
-}
-
void ConsoleMessage::windowCleared(DOMWindow* window)
{
if (!m_arguments)

Powered by Google App Engine
This is Rietveld 408576698