Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: Source/devtools/front_end/ConsoleView.js

Issue 185713007: DevTools: Add timestamp support in the console (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 * @param {!WebInspector.ConsoleMessage} message 415 * @param {!WebInspector.ConsoleMessage} message
416 */ 416 */
417 _consoleMessageAdded: function(target, message) 417 _consoleMessageAdded: function(target, message)
418 { 418 {
419 if (this._urlToMessageCount[message.url]) 419 if (this._urlToMessageCount[message.url])
420 this._urlToMessageCount[message.url]++; 420 this._urlToMessageCount[message.url]++;
421 else 421 else
422 this._urlToMessageCount[message.url] = 1; 422 this._urlToMessageCount[message.url] = 1;
423 423
424 if (this._previousMessage && !message.isGroupMessage() && message.isEqua l(this._previousMessage)) { 424 if (this._previousMessage && !message.isGroupMessage() && message.isEqua l(this._previousMessage)) {
425 this._messageToViewMessage.get(this._previousMessage).incrementRepea tCount(); 425 this._messageToViewMessage.get(this._previousMessage).incrementRepea tCount(message.timestamp);
apavlov 2014/03/26 11:53:10 I'd rename this method to avoid any confusion
426 return; 426 return;
427 } 427 }
428 428
429 this._consoleMessages.push(message); 429 this._consoleMessages.push(message);
430 this._previousMessage = message; 430 this._previousMessage = message;
431 var viewMessage = this._createViewMessage(target, message); 431 var viewMessage = this._createViewMessage(target, message);
432 432
433 if (this._filter.shouldBeVisible(viewMessage)) 433 if (this._filter.shouldBeVisible(viewMessage))
434 this._showConsoleMessage(viewMessage); 434 this._showConsoleMessage(viewMessage);
435 else 435 else
(...skipping 738 matching lines...) Expand 10 before | Expand all | Expand 10 after
1174 var node = this.messagesElement.firstChild; 1174 var node = this.messagesElement.firstChild;
1175 while (node) { 1175 while (node) {
1176 if (node.classList.contains("console-message") && node.message) 1176 if (node.classList.contains("console-message") && node.message)
1177 node.message.wasShown(); 1177 node.message.wasShown();
1178 if (node.classList.contains("console-group") && node.group) 1178 if (node.classList.contains("console-group") && node.group)
1179 node.group.wasShown(); 1179 node.group.wasShown();
1180 node = node.nextSibling; 1180 node = node.nextSibling;
1181 } 1181 }
1182 } 1182 }
1183 } 1183 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ConsoleModel.js ('k') | Source/devtools/front_end/ConsoleViewMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698