DevTools: Add timestamp support in the console

Source/devtools/front_end/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 32 matching lines @@
     this._dataGrids = [];
     /** @type {!Map.<!WebInspector.DataGrid, ?Element>} */
     this._dataGridParents = new Map();
 
     this._customFormatters = {
         "object": this._formatParameterAsObject,
         "array":  this._formatParameterAsArray,
         "node":   this._formatParameterAsNode,
         "string": this._formatParameterAsString
     };
+
+     WebInspector.settings.consoleTimestampsEnabled.addChangeListener(this._consoleTimestampsSettingChanged.bind(this));

[apavlov, 2014/03/21 09:30:46]

WebInspector.settings.consoleTimestampsEnabled.addChangeListener(this._consoleTimestampsSettingChanged,
this);

 }
 
+

[apavlov, 2014/03/21 09:30:46]

extra line added

 WebInspector.ConsoleViewMessage.prototype = {
     wasShown: function()
     {
         for (var i = 0; this._dataGrids && i < this._dataGrids.length; ++i) {
             var dataGrid = this._dataGrids[i];
             var parentElement = this._dataGridParents.get(dataGrid) || null;
             dataGrid.show(parentElement);
             dataGrid.updateWidths();
         }
     },
@@ skipping 771 matching lines @@
 
     /**
      * @return {boolean}
      */
     matchesRegex: function(regexObject)
     {
         regexObject.lastIndex = 0;
         return regexObject.test(this._formattedMessageText()) || (!!this._anchorElement && regexObject.test(this._anchorElement.textContent));
     },
 
+    _updateTimestamp: function(show)
+    {
+        if (!this._element)
+            return;
+
+        if (!this.timestampElement) {

[apavlov, 2014/03/21 09:30:46]

don't we want the timestampElements to be lazily created only when necessary?

+            this.timestampElement = this._element.createChild("span", "console-timestamp");
+            this._element.insertBefore(this.timestampElement, this._element.firstChild);
+        }
+
+        if (show) {
+            this.timestampElement.textContent = (new Date(this._message.timestamp)).toConsoleTime();
+            this.timestampElement.classList.remove("hidden");
+        } else {
+            this.timestampElement.textContent = "";

[apavlov, 2014/03/21 09:30:46]

...and removed when no longer needed?

That can save us hundreds of extra elements in the page

+            this.timestampElement.classList.add("hidden");
+        }
+    },
+
+    _consoleTimestampsSettingChanged: function(event)
+    {
+        var enabled = /** @type {boolean} */ (event.data);
+        this._updateTimestamp(enabled);
+    },
+
     /**
      * @return {!Element}
      */
     toMessageElement: function()
     {
         if (this._element)
             return this._element;
 
         var element = document.createElement("div");
         element.message = this;
@@ skipping 19 matching lines @@
             break;
         }
 
         if (this._message.type === WebInspector.ConsoleMessage.MessageType.StartGroup || this._message.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed)
             element.classList.add("console-group-title");
 
         element.appendChild(this.formattedMessage());
 
         if (this._message.repeatCount > 1)
             this.updateRepeatCount();
+        this._updateTimestamp(WebInspector.settings.consoleTimestampsEnabled.get());
 
         return element;
     },
 
     _populateStackTraceTreeElement: function(parentTreeElement)
     {
         for (var i = 0; i < this._message.stackTrace.length; i++) {
             var frame = this._message.stackTrace[i];
 
             var content = document.createElementWithClass("div", "stacktrace-entry");
@@ skipping 122 matching lines @@
         }
 
         return sourceString + " " + typeString + " " + levelString + ": " + this.formattedMessage().textContent + "\n" + this._message.url + " line " + this._message.line;
     },
 
     get text()
     {
         return this._message.messageText;
     }
 }