LayoutTests/inspector/console/console-timestamp.html - Issue 185713007: DevTools: Add timestamp support in the console

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/console/console-timestamp.html

Issue 185713007: DevTools: Add timestamp support in the console (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Up for review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/inspector/console/console-object-preview-expected.txt ('k') | LayoutTests/inspector/console/console-timestamp-expected.txt » ('j') | Source/core/inspector/InspectorConsoleAgent.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../http/tests/inspector/console-test.js"></script>

	5 <script>

	6 function test()

	7 {

	8 function addMessageWithFixedTimestamp(timestamp)

	9 {

	10 var message = new WebInspector.ConsoleMessage(

	11 WebInspector.ConsoleMessage.MessageSource.Other, // source

	12 WebInspector.ConsoleMessage.MessageLevel.Log, // level

	13 "Console message text.", // messageText

	14 undefined, // type

	15 undefined, // url

	16 undefined, // line

	17 undefined, // column

	18 undefined, // requestId

	19 undefined, // parameters

	20 undefined, // stackTrace

	21 timestamp \|\| 1400000000123, // timestamp: 2014-05-13T16:53:20.123Z

	22 false); // isOutdated

	23 WebInspector.console.addMessage(message, true); // allowGrouping

	24 }

	25

	26 // 1. Ensure no timestamp, just message.
	apavlov 2014/03/21 09:30:46 unnecessary comment. Instead, add InspectorTest.ad unnecessary comment. Instead, add InspectorTest.addResult("Console messages with timestamps disabled"); just before the first dumpConsoleMessages call.
	27 for (var i = 0; i < 2; i++) {
	apavlov 2014/03/21 09:30:46 You can just write addMessageWithFixedTimestamp(); You can just write addMessageWithFixedTimestamp(); addMessageWithFixedTimestamp(); which will save us one line :) Actually, you don't need braces for single-line blocks in Blink
	28 addMessageWithFixedTimestamp();

	29 }

	30 addMessageWithFixedTimestamp(1400000000456);

	31

	32 InspectorTest.dumpConsoleMessages();

	33

	34 WebInspector.settings.consoleTimestampsEnabled.set(true);

	35

	36 for (var i = 0; i < 2; i++) {
	apavlov 2014/03/21 09:30:46 Ditto Ditto
	37 addMessageWithFixedTimestamp();

	38 }

	39 addMessageWithFixedTimestamp(1400000000456);

	40

	41 InspectorTest.dumpConsoleMessages();
	apavlov 2014/03/21 09:30:46 Add InspectorTest.addResult("Console messages with Add InspectorTest.addResult("Console messages with timestamps enabled"); before this line
	42 InspectorTest.completeTest();

	43 }

	44 </script>

	45 </head>

	46 <body onload="runTest()">

	47 <p>

	48 Tests the console timestamp setting

	49 </p>

	50 </body>

	51 </html>

OLD	NEW