Add support for FreeBSD in base/ , base/process/ , and base/threading so that the bootstrap binary …

Add support for FreeBSD in base/ , base/process/ , and base/threading so that the bootstrap binary for GN (the one in TEMPDIR) can be built and run.

Tested on FreeBSD 8.4-i386 and FreeBSD 10.0-amd64

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256124

[r.c.ladan, 2014-03-10 16:18:41]

This (FreeBSD-specific) change is not only required for GN but also for Chromium
itself.

[Raphael Kubo da Costa (rakuco), 2014-03-10 19:55:42]

+Nico

[Nico, 2014-03-10 19:58:32]

I'm a bit scared of the change in the first file, other than that looks fine

https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc
File base/file_util_posix.cc (right):

https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc#newc...
base/file_util_posix.cc:678: #if defined(OS_MACOSX) || (defined(OS_FREEBSD) &&
__FreeBSD_version < 900000)
Is it reasonable to only support __FreeBSD_version >=  900000?

https://codereview.chromium.org/185713005/diff/1/base/process/process_iterato...
File base/process/process_iterator_freebsd.cc (right):

https://codereview.chromium.org/185713005/diff/1/base/process/process_iterato...
base/process/process_iterator_freebsd.cc:9: 
no newline here

[r.c.ladan, 2014-03-10 20:08:01]

https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc
File base/file_util_posix.cc (right):

https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc#newc...
base/file_util_posix.cc:678: #if defined(OS_MACOSX) || (defined(OS_FREEBSD) &&
__FreeBSD_version < 900000)
On 2014/03/10 19:58:33, Nico wrote:
> Is it reasonable to only support __FreeBSD_version >=  900000?

FreeBSD 8.X will be supported until 2015-06-30, so I prefer to keep it in.

[Nico, 2014-03-10 20:16:17]

On 2014/03/10 20:08:01, r.c.ladan wrote:
> https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc
> File base/file_util_posix.cc (right):
> 
>
https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc#newc...
> base/file_util_posix.cc:678: #if defined(OS_MACOSX) || (defined(OS_FREEBSD) &&
> __FreeBSD_version < 900000)
> On 2014/03/10 19:58:33, Nico wrote:
> > Is it reasonable to only support __FreeBSD_version >=  900000?
> 
> FreeBSD 8.X will be supported until 2015-06-30, so I prefer to keep it in.

How many more places will need version-specific stuff like this?

[r.c.ladan, 2014-03-10 20:19:02]

https://codereview.chromium.org/185713005/diff/1/base/process/process_iterato...
File base/process/process_iterator_freebsd.cc (right):

https://codereview.chromium.org/185713005/diff/1/base/process/process_iterato...
base/process/process_iterator_freebsd.cc:9: 
On 2014/03/10 19:58:33, Nico wrote:
> no newline here

Done.

[r.c.ladan, 2014-03-10 20:23:54]

On 2014/03/10 20:16:17, Nico wrote:
> On 2014/03/10 20:08:01, r.c.ladan wrote:
> > https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc
> > File base/file_util_posix.cc (right):
> > 
> >
>
https://codereview.chromium.org/185713005/diff/1/base/file_util_posix.cc#newc...
> > base/file_util_posix.cc:678: #if defined(OS_MACOSX) || (defined(OS_FREEBSD)
&&
> > __FreeBSD_version < 900000)
> > On 2014/03/10 19:58:33, Nico wrote:
> > > Is it reasonable to only support __FreeBSD_version >=  900000?
> > 
> > FreeBSD 8.X will be supported until 2015-06-30, so I prefer to keep it in.
> 
> How many more places will need version-specific stuff like this?

In the current patchset there might be one more file,
base/strings/safe_sprintf.cc, but ideally that check should be only on the C++
library type/version.

[Nico, 2014-03-10 20:25:48]

lgtm

[r.c.ladan, 2014-03-10 20:27:09]

The CQ bit was checked by r.c.ladan@gmail.com

[commit-bot: I haz the power, 2014-03-10 20:29:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/185713005/20001

[commit-bot: I haz the power, 2014-03-10 21:49:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/185713005/20001

[commit-bot: I haz the power, 2014-03-10 22:32:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/185713005/20001

[commit-bot: I haz the power, 2014-03-10 23:47:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/185713005/20001

[commit-bot: I haz the power, 2014-03-11 04:11:13]

Change committed as 256124