Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857123002: Add a shortcut key (Alt+F) to open the gear menu in Files.app (Closed)

Created:
4 years, 8 months ago by oka
Modified:
4 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a shortcut key (Alt+F) to open the gear menu in Files.app BUG=600231 TEST=manually Committed: https://crrev.com/92f88c836f998ecf5d5cf34b9c5241c3386f2841 Cr-Commit-Position: refs/heads/master@{#385110}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
oka
PTAL
4 years, 8 months ago (2016-04-05 03:57:28 UTC) #3
fukino
https://codereview.chromium.org/1857123002/diff/1/ui/file_manager/file_manager/main.html File ui/file_manager/file_manager/main.html (right): https://codereview.chromium.org/1857123002/diff/1/ui/file_manager/file_manager/main.html#newcode121 ui/file_manager/file_manager/main.html:121: <command id="open-gear-menu" shortcut="U+0046-Alt"> Maybe 'shortcut="U+0045-Alt U+0046-Alt"' works?
4 years, 8 months ago (2016-04-05 03:59:39 UTC) #4
oka
https://codereview.chromium.org/1857123002/diff/1/ui/file_manager/file_manager/main.html File ui/file_manager/file_manager/main.html (right): https://codereview.chromium.org/1857123002/diff/1/ui/file_manager/file_manager/main.html#newcode121 ui/file_manager/file_manager/main.html:121: <command id="open-gear-menu" shortcut="U+0046-Alt"> On 2016/04/05 03:59:39, fukino wrote: > ...
4 years, 8 months ago (2016-04-05 04:06:53 UTC) #5
oka
https://codereview.chromium.org/1857123002/diff/1/ui/file_manager/file_manager/main.html File ui/file_manager/file_manager/main.html (right): https://codereview.chromium.org/1857123002/diff/1/ui/file_manager/file_manager/main.html#newcode121 ui/file_manager/file_manager/main.html:121: <command id="open-gear-menu" shortcut="U+0046-Alt"> On 2016/04/05 03:59:39, fukino wrote: > ...
4 years, 8 months ago (2016-04-05 04:06:53 UTC) #6
fukino
lgtm
4 years, 8 months ago (2016-04-05 04:08:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857123002/20001
4 years, 8 months ago (2016-04-05 05:12:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 05:44:04 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 05:45:23 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/92f88c836f998ecf5d5cf34b9c5241c3386f2841
Cr-Commit-Position: refs/heads/master@{#385110}

Powered by Google App Engine
This is Rietveld 408576698