chrome/browser/ui/cocoa/tabs/tab_window_controller.mm - Issue 1857093002: [Mac] Fix tabstrip background opacity problem when dragging tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Issue 1857093002: [Mac] Fix tabstrip background opacity problem when dragging tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rework tab dragging detection. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

index db17dac813da53a9f734fd1aceba2850d8737a8e..01dcdc06a90769fac428d92e265298094e0fbf1d 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

@@ -178,6 +178,7 @@

// content view (rather than using setContentView:) because the overlay

// window has a different content size (due to it being borderless).

[[overlayWindow_ contentView] addSubview:[self tabStripView]];

+ [[self tabStripView] setInATabDraggingOverlayWindow:YES];

[[overlayWindow_ contentView] addSubview:originalContentView_];

[overlayWindow_ orderFront:nil];

@@ -193,6 +194,7 @@

relativeTo:nil];

originalContentView_.frame = [[window contentView] bounds];

[[window contentView] addSubview:[self tabStripView]];

+ [[self tabStripView] setInATabDraggingOverlayWindow:NO];

[[window contentView] updateTrackingAreas];

[focusBeforeOverlay_ restoreFocusInWindow:window];

« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_view.mm ('k') | no next file » | no next file with comments »