Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

Issue 1857083002: Segment strings on dot and comma in addition to space and tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
index a8623c6063f09a4aa66ddbef068ad9deda1373fd..15ddda57b7ef88eaea326b3b65d27c09e2949b9e 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
@@ -65,9 +65,15 @@ TEST_F(CachingWordShaperTest, LatinLeftToRightByWord)
ASSERT_TRUE(iterator.next(&result));
ASSERT_TRUE(testInfo(result)->runInfoForTesting(0, startIndex, numGlyphs, script));
EXPECT_EQ(0u, startIndex);
- EXPECT_EQ(4u, numGlyphs);
+ EXPECT_EQ(3u, numGlyphs);
EXPECT_EQ(HB_SCRIPT_LATIN, script);
+ ASSERT_TRUE(iterator.next(&result));
+ ASSERT_TRUE(testInfo(result)->runInfoForTesting(0, startIndex, numGlyphs, script));
+ EXPECT_EQ(0u, startIndex);
+ EXPECT_EQ(1u, numGlyphs);
+ EXPECT_EQ(HB_SCRIPT_COMMON, script);
+
ASSERT_FALSE(iterator.next(&result));
}
@@ -82,7 +88,14 @@ TEST_F(CachingWordShaperTest, CommonAccentLeftToRightByWord)
ASSERT_TRUE(iterator.next(&result));
ASSERT_TRUE(testInfo(result)->runInfoForTesting(0, startIndex, numGlyphs, script));
EXPECT_EQ(0u, offset + startIndex);
- EXPECT_EQ(3u, numGlyphs);
+ EXPECT_EQ(2u, numGlyphs);
+ EXPECT_EQ(HB_SCRIPT_COMMON, script);
+ offset += result->numCharacters();
+
+ ASSERT_TRUE(iterator.next(&result));
+ ASSERT_TRUE(testInfo(result)->runInfoForTesting(0, startIndex, numGlyphs, script));
+ EXPECT_EQ(2u, offset + startIndex);
+ EXPECT_EQ(1u, numGlyphs);
EXPECT_EQ(HB_SCRIPT_COMMON, script);
offset += result->numCharacters();
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698