Make down-conversion explicit from CFX_Widetring to CFX_WideStringC.

xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"
 
 #include <time.h>
 
@@ skipping 1571 matching lines @@
       IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
       IFX_Locale* pLocale = NULL;
       if (localString.IsEmpty()) {
         CXFA_Node* pThisNode =
             ToNode(pDoc->GetScriptContext()->GetThisObject());
         FXSYS_assert(pThisNode);
         CXFA_WidgetData widgetData(pThisNode);
         pLocale = widgetData.GetLocal();
       } else {
         pLocale = pMgr->GetLocaleByName(
-            CFX_WideString::FromUTF8(localString, localString.GetLength()));
+            CFX_WideString::FromUTF8(localString, localString.GetLength())
+                .AsWideStringC());
       }
       CFX_WideString wsFormat;
       if (formatString.IsEmpty()) {
         pLocale->GetTimePattern(FX_LOCALEDATETIMESUBCATEGORY_Default, wsFormat);
       } else {
         wsFormat =
             CFX_WideString::FromUTF8(formatString, formatString.GetLength());
       }
       wsFormat = FX_WSTRC(L"time{") + wsFormat;
       wsFormat += FX_WSTRC(L"}");
@@ skipping 429 matching lines @@
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
     CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
     FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
-        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
+        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength())
+            .AsWideStringC());
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
     pLocale->GetDatePattern(FX_LOCALEDATETIMESUBCATEGORY_Default, wsFormat);
   } else {
     wsFormat =
         CFX_WideString::FromUTF8(szFormat.GetCStr(), szFormat.GetLength());
@@ skipping 19 matching lines @@
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
     CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
     FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
-        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
+        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength())
+            .AsWideStringC());
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
     pLocale->GetTimePattern(FX_LOCALEDATETIMESUBCATEGORY_Default, wsFormat);
   } else {
     wsFormat =
         CFX_WideString::FromUTF8(szFormat.GetCStr(), szFormat.GetLength());
@@ skipping 22 matching lines @@
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
     CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
     FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
-        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
+        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength())
+            .AsWideStringC());
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
     pLocale->GetDatePattern(FX_LOCALEDATETIMESUBCATEGORY_Default, wsFormat);
   } else {
     wsFormat =
         CFX_WideString::FromUTF8(szFormat.GetCStr(), szFormat.GetLength());
@@ skipping 21 matching lines @@
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
     CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
     FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
-        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
+        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength())
+            .AsWideStringC());
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
     pLocale->GetTimePattern(FX_LOCALEDATETIMESUBCATEGORY_Default, wsFormat);
   } else {
     wsFormat =
         CFX_WideString::FromUTF8(szFormat.GetCStr(), szFormat.GetLength());
@@ skipping 23 matching lines @@
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
     CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
     FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
-        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
+        CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength())
+            .AsWideStringC());
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
     pLocale->GetTimePattern(FX_LOCALEDATETIMESUBCATEGORY_Default, wsFormat);
   } else {
     wsFormat =
         CFX_WideString::FromUTF8(szFormat.GetCStr(), szFormat.GetLength());
@@ skipping 164 matching lines @@
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocalStr.IsEmpty()) {
     CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
     FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
-        CFX_WideString::FromUTF8(szLocalStr.GetCStr(), szLocalStr.GetLength()));
+        CFX_WideString::FromUTF8(szLocalStr.GetCStr(), szLocalStr.GetLength())
+            .AsWideStringC());
   }
   if (!pLocale) {
     return;
   }
   CFX_WideString strRet;
   pLocale->GetDatePattern(strStyle, strRet);
   if (!bStandard) {
     CFX_WideString wsSymbols;
     pLocale->GetDateTimeSymbols(wsSymbols);
     XFA_FM_AlternateDateTimeSymbols(strRet, wsSymbols, g_sAltTable_Date);
@@ skipping 34 matching lines @@
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocalStr.IsEmpty()) {
     CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
     FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
-        CFX_WideString::FromUTF8(szLocalStr.GetCStr(), szLocalStr.GetLength()));
+        CFX_WideString::FromUTF8(szLocalStr.GetCStr(), szLocalStr.GetLength())
+            .AsWideStringC());
   }
   if (!pLocale) {
     return;
   }
   CFX_WideString strRet;
   pLocale->GetTimePattern(strStyle, strRet);
   if (!bStandard) {
     CFX_WideString wsSymbols;
     pLocale->GetDateTimeSymbols(wsSymbols);
     XFA_FM_AlternateDateTimeSymbols(strRet, wsSymbols, g_sAltTable_Time);
@@ skipping 798 matching lines @@
   if (args.GetLength() == 1) {
     FXJSE_HVALUE scriptValue = GetSimpleHValue(hThis, args, 0);
     CFX_ByteString utf8ScriptString;
     HValueToUTF8String(scriptValue, utf8ScriptString);
     if (utf8ScriptString.IsEmpty()) {
       FXJSE_Value_SetNull(args.GetReturnValue());
     } else {
       CFX_WideTextBuf wsJavaScriptBuf;
       CFX_WideString javaScript;
       CFX_WideString wsError;
-      XFA_FM2JS_Translate(CFX_WideString::FromUTF8(
-                              utf8ScriptString, utf8ScriptString.GetLength()),
+      XFA_FM2JS_Translate(CFX_WideString::FromUTF8(utf8ScriptString,
+                                                   utf8ScriptString.GetLength())
+                              .AsWideStringC(),
                           wsJavaScriptBuf, wsError);
       FXJSE_HCONTEXT hContext = FXJSE_Context_Create(hruntime);
       FXJSE_HVALUE returnValue = FXJSE_Value_Create(hruntime);
       javaScript = wsJavaScriptBuf.GetWideString();
       FXJSE_ExecuteScript(hContext,
                           FX_UTF8Encode(javaScript, javaScript.GetLength()),
                           returnValue);
       FXJSE_Value_Set(args.GetReturnValue(), returnValue);
       FXJSE_Value_Release(returnValue);
       FXJSE_Context_Release(hContext);
@@ skipping 2202 matching lines @@
     }
     IXFA_AppProvider* pAppProvider =
         pDoc->GetParser()->GetNotify()->GetAppProvider();
     if (!pAppProvider) {
       return;
     }
     FXJSE_HVALUE argOne = GetSimpleHValue(hThis, args, 0);
     CFX_ByteString urlString;
     HValueToUTF8String(argOne, urlString);
     IFX_FileRead* pFile = pAppProvider->DownloadURL(
-        CFX_WideString::FromUTF8(urlString, urlString.GetLength()));
+        CFX_WideString::FromUTF8(urlString, urlString.GetLength())
+            .AsWideStringC());
     if (pFile) {
       int32_t size = pFile->GetSize();
       uint8_t* pData = FX_Alloc(uint8_t, size);
       pFile->ReadBlock(pData, size);
       FXJSE_Value_SetUTF8String(args.GetReturnValue(),
                                 CFX_ByteStringC(pData, size));
       FX_Free(pData);
       pFile->Release();
     }
     FXJSE_Value_Release(argOne);
@@ skipping 39 matching lines @@
     if (argc > 3) {
       argFour = GetSimpleHValue(hThis, args, 3);
       HValueToUTF8String(argFour, bsEncode);
     }
     if (argc > 4) {
       argFive = GetSimpleHValue(hThis, args, 4);
       HValueToUTF8String(argFive, bsHeader);
     }
     CFX_WideString decodedResponse;
     FX_BOOL bFlags = pAppProvider->PostRequestURL(
-        CFX_WideString::FromUTF8(bsURL, bsURL.GetLength()),
-        CFX_WideString::FromUTF8(bsData, bsData.GetLength()),
-        CFX_WideString::FromUTF8(bsContentType, bsContentType.GetLength()),
-        CFX_WideString::FromUTF8(bsEncode, bsEncode.GetLength()),
-        CFX_WideString::FromUTF8(bsHeader, bsHeader.GetLength()),
+        CFX_WideString::FromUTF8(bsURL, bsURL.GetLength()).AsWideStringC(),
+        CFX_WideString::FromUTF8(bsData, bsData.GetLength()).AsWideStringC(),
+        CFX_WideString::FromUTF8(bsContentType, bsContentType.GetLength())
+            .AsWideStringC(),
+        CFX_WideString::FromUTF8(bsEncode, bsEncode.GetLength())
+            .AsWideStringC(),
+        CFX_WideString::FromUTF8(bsHeader, bsHeader.GetLength())
+            .AsWideStringC(),
         decodedResponse);
     FXJSE_Value_Release(argOne);
     FXJSE_Value_Release(argTwo);
     if (argc > 2) {
       FXJSE_Value_Release(argThree);
     }
     if (argc > 3) {
       FXJSE_Value_Release(argFour);
     }
     if (argc > 4) {
@@ skipping 36 matching lines @@
     FXJSE_HVALUE argThree;
     argOne = GetSimpleHValue(hThis, args, 0);
     HValueToUTF8String(argOne, bsURL);
     argTwo = GetSimpleHValue(hThis, args, 1);
     HValueToUTF8String(argTwo, bsData);
     if (argc > 2) {
       argThree = GetSimpleHValue(hThis, args, 2);
       HValueToUTF8String(argThree, bsEncode);
     }
     FX_BOOL bFlags = pAppProvider->PutRequestURL(
-        CFX_WideString::FromUTF8(bsURL, bsURL.GetLength()),
-        CFX_WideString::FromUTF8(bsData, bsData.GetLength()),
-        CFX_WideString::FromUTF8(bsEncode, bsEncode.GetLength()));
+        CFX_WideString::FromUTF8(bsURL, bsURL.GetLength()).AsWideStringC(),
+        CFX_WideString::FromUTF8(bsData, bsData.GetLength()).AsWideStringC(),
+        CFX_WideString::FromUTF8(bsEncode, bsEncode.GetLength())
+            .AsWideStringC());
     FXJSE_Value_Release(argOne);
     FXJSE_Value_Release(argTwo);
     if (argc > 2) {
       FXJSE_Value_Release(argThree);
     }
     if (bFlags) {
       FXJSE_Value_SetUTF8String(args.GetReturnValue(), "");
     } else {
       pContext->ThrowScriptErrorMessage(XFA_IDS_SERVER_DENY);
     }
@@ skipping 785 matching lines @@
     FXJSE_HVALUE argOne = GetSimpleHValue(hThis, args, 0);
     CFX_ByteString argString;
     HValueToUTF8String(argOne, argString);
     if (argString.IsEmpty()) {
       pContext->ThrowScriptErrorMessage(XFA_IDS_ARGUMENT_MISMATCH);
     } else {
       CFX_WideString scriptString =
           CFX_WideString::FromUTF8(argString, argString.GetLength());
       CFX_WideTextBuf wsJavaScriptBuf;
       CFX_WideString wsError;
-      XFA_FM2JS_Translate(scriptString, wsJavaScriptBuf, wsError);
+      XFA_FM2JS_Translate(scriptString.AsWideStringC(), wsJavaScriptBuf,
+                          wsError);
       if (wsError.IsEmpty()) {
         CFX_WideString javaScript = wsJavaScriptBuf.GetWideString();
         FXJSE_Value_SetUTF8String(
             args.GetReturnValue(),
             FX_UTF8Encode(javaScript, javaScript.GetLength()).AsByteStringC());
       } else {
         pContext->ThrowScriptErrorMessage(XFA_IDS_COMPILER_ERROR);
       }
     }
     FXJSE_Value_Release(argOne);
@@ skipping 448 matching lines @@
   if (!pDoc) {
     return bFlags;
   }
   CXFA_ScriptContext* pScriptContext = pDoc->GetScriptContext();
   XFA_RESOLVENODE_RS resoveNodeRS;
   uint32_t dwFlags = XFA_RESOLVENODE_Children | XFA_RESOLVENODE_Properties |
                      XFA_RESOLVENODE_Siblings | XFA_RESOLVENODE_Parent;
   int32_t iRet = pScriptContext->ResolveObjects(
       pScriptContext->GetThisObject(),
       CFX_WideString::FromUTF8(szAccessorName.GetCStr(),
-                               szAccessorName.GetLength()),
+                               szAccessorName.GetLength())
+          .AsWideStringC(),
       resoveNodeRS, dwFlags);
   if (iRet >= 1 && resoveNodeRS.dwFlags == XFA_RESOVENODE_RSTYPE_Nodes) {
     FXJSE_Value_Set(accessorValue, pScriptContext->GetJSValueFromMap(
                                        resoveNodeRS.nodes.GetAt(0)));
     bFlags = TRUE;
   }
   return bFlags;
 }
 int32_t CXFA_FM2JSContext::ResolveObjects(FXJSE_HOBJECT hThis,
                                           FXJSE_HVALUE hRefValue,
@@ skipping 36 matching lines @@
         dFlags = (bsSomExp == "*")
                      ? (XFA_RESOLVENODE_Children)
                      : (XFA_RESOLVENODE_Children | XFA_RESOLVENODE_Attributes |
                         XFA_RESOLVENODE_Properties);
       }
     }
   } else {
     pNode = (CXFA_Object*)FXJSE_Value_ToObject(hRefValue, NULL);
     dFlags = XFA_RESOLVENODE_AnyChild;
   }
-  iRet = pScriptContext->ResolveObjects(pNode, wsSomExpression, resoveNodeRS,
-                                        dFlags);
+  iRet = pScriptContext->ResolveObjects(pNode, wsSomExpression.AsWideStringC(),
+                                        resoveNodeRS, dFlags);
   return iRet;
 }
 void CXFA_FM2JSContext::ParseResolveResult(
     FXJSE_HOBJECT hThis,
     const XFA_RESOLVENODE_RS& resoveNodeRS,
     FXJSE_HVALUE hParentValue,
     FXJSE_HVALUE*& resultValues,
     int32_t& iSize,
     FX_BOOL& bAttribute) {
   CXFA_FM2JSContext* pContext =
@@ skipping 305 matching lines @@
   CFX_WideString wsFormat;
   pAppProvider->LoadString(iStringID, wsFormat);
   CFX_WideString wsMessage;
   va_list arg_ptr;
   va_start(arg_ptr, iStringID);
   wsMessage.FormatV((const FX_WCHAR*)wsFormat, arg_ptr);
   va_end(arg_ptr);
   FXJSE_ThrowMessage(
       "", FX_UTF8Encode(wsMessage, wsMessage.GetLength()).AsByteStringC());
 }