Implement tab indicator for WebUSB.

Implement tab indicator for WebUSB.

When a frame within a tab has a USB device open a tab indicator is
displayed to alert the user to the ongoing connection.

BUG=592105
Committed: https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0
Cr-Commit-Position: refs/heads/master@{#386151}

[Reilly Grant (use Gerrit), 2016-04-05 18:27:01]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2016-04-05 18:30:37]

reillyg@chromium.org changed reviewers:
+ estade@chromium.org, jochen@chromium.org, miu@chromium.org,
oshima@chromium.org

[Reilly Grant (use Gerrit), 2016-04-05 18:30:38]

oshima@, please review //chrome/app/theme.
miu@, please review //chrome/browser/ui/tabs.
jochen@, please review //content.
estade@, please review //ui/gfx/vector_icons.

[Evan Stade, 2016-04-05 18:55:52]

lgtm

[oshima, 2016-04-05 21:33:12]

c/a/theme lgtm

[miu, 2016-04-05 22:38:11]

lgtm

[jochen (gone - plz use gerrit), 2016-04-06 04:17:31]

why are we storing this state in the web contents? content shouldn't care about
tab ui

[Reilly Grant (use Gerrit), 2016-04-07 00:38:53]

On 2016/04/06 at 04:17:31, jochen wrote:
> why are we storing this state in the web contents? content shouldn't care
about tab ui

The state has nothing to do with tab UI. It is simply allowing the content
embedder to discover whether or not the WebContents is using various features.

[jochen (gone - plz use gerrit), 2016-04-07 01:22:41]

On 2016/04/07 at 00:38:53, reillyg wrote:
> On 2016/04/06 at 04:17:31, jochen wrote:
> > why are we storing this state in the web contents? content shouldn't care
about tab ui
> 
> The state has nothing to do with tab UI. It is simply allowing the content
embedder to discover whether or not the WebContents is using various features.

But the embedder already knows. The increment and decrement are done from
chrome/ - just query the permission provider instead of storing the count in
content/

[Reilly Grant (use Gerrit), 2016-04-07 21:06:02]

On 2016/04/07 at 01:22:41, jochen wrote:
> On 2016/04/07 at 00:38:53, reillyg wrote:
> > On 2016/04/06 at 04:17:31, jochen wrote:
> > > why are we storing this state in the web contents? content shouldn't care
about tab ui
> > 
> > The state has nothing to do with tab UI. It is simply allowing the content
embedder to discover whether or not the WebContents is using various features.
> 
> But the embedder already knows. The increment and decrement are done from
chrome/ - just query the permission provider instead of storing the count in
content/

Done, miu@ please take another look at tab_utils.cc and my calls into the
TabStripModel in usb_tab_helper.cc.

[miu, 2016-04-08 18:23:03]

lgtm % one consideration:

https://codereview.chromium.org/1857033003/diff/60001/chrome/browser/usb/web_...
File chrome/browser/usb/web_usb_permission_provider.cc (right):

https://codereview.chromium.org/1857033003/diff/60001/chrome/browser/usb/web_...
chrome/browser/usb/web_usb_permission_provider.cc:122: UsbTabHelper* tab_helper
= UsbTabHelper::FromWebContents(web_contents);
Seems like this should be a call to GetOrCreateFromWebContents().  Unless you
know somehow that there *must* be a UsbTabHelper instance already associated
with the WebContents when the first increment occurs?  And, if that's the case,
consider whether you feel that's a safe assumption for the code here.

[Reilly Grant (use Gerrit), 2016-04-08 18:26:32]

https://codereview.chromium.org/1857033003/diff/60001/chrome/browser/usb/web_...
File chrome/browser/usb/web_usb_permission_provider.cc (right):

https://codereview.chromium.org/1857033003/diff/60001/chrome/browser/usb/web_...
chrome/browser/usb/web_usb_permission_provider.cc:122: UsbTabHelper* tab_helper
= UsbTabHelper::FromWebContents(web_contents);
On 2016/04/08 at 18:23:03, miu wrote:
> Seems like this should be a call to GetOrCreateFromWebContents().  Unless you
know somehow that there *must* be a UsbTabHelper instance already associated
with the WebContents when the first increment occurs?  And, if that's the case,
consider whether you feel that's a safe assumption for the code here.

Yes, if we've gotten here then there must be a UsbTabHelper as the UsbTabHelper
is what creates this object.

[miu, 2016-04-08 18:28:21]

still lgtm

https://codereview.chromium.org/1857033003/diff/60001/chrome/browser/usb/web_...
File chrome/browser/usb/web_usb_permission_provider.cc (right):

https://codereview.chromium.org/1857033003/diff/60001/chrome/browser/usb/web_...
chrome/browser/usb/web_usb_permission_provider.cc:122: UsbTabHelper* tab_helper
= UsbTabHelper::FromWebContents(web_contents);
On 2016/04/08 18:26:32, Reilly Grant wrote:
> On 2016/04/08 at 18:23:03, miu wrote:
> > Seems like this should be a call to GetOrCreateFromWebContents().  Unless
you
> know somehow that there *must* be a UsbTabHelper instance already associated
> with the WebContents when the first increment occurs?  And, if that's the
case,
> consider whether you feel that's a safe assumption for the code here.
> 
> Yes, if we've gotten here then there must be a UsbTabHelper as the
UsbTabHelper
> is what creates this object.

Sounds good.  Just checking.  :)

[Reilly Grant (use Gerrit), 2016-04-08 18:41:14]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-08 18:41:14]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1857033003/#ps60001
(title: "Don't try to update tab indicator on Android.")

[commit-bot: I haz the power, 2016-04-08 18:42:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857033003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857033003/60001

[commit-bot: I haz the power, 2016-04-08 18:52:56]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-08 18:55:20]

Description was changed from

==========
Implement tab indicator for WebUSB.

When a frame within a tab has a USB device open a tab indicator is
displayed to alert the user to the ongoing connection.

BUG=592105
==========

to

==========
Implement tab indicator for WebUSB.

When a frame within a tab has a USB device open a tab indicator is
displayed to alert the user to the ongoing connection.

BUG=592105

Committed: https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0
Cr-Commit-Position: refs/heads/master@{#386151}
==========

[commit-bot: I haz the power, 2016-04-08 18:55:21]

Patchset 3 (id:??) landed as
https://crrev.com/3e1eacc3ed0445d768faec12f11d86b6b53ca1e0
Cr-Commit-Position: refs/heads/master@{#386151}