Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: device/usb/mock_usb_device.cc

Issue 1857033002: Include USB device version in chrome.usb.Device fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | device/usb/mojo/type_converters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/mock_usb_device.cc
diff --git a/device/usb/mock_usb_device.cc b/device/usb/mock_usb_device.cc
index 49b2252ac346b96c25497ab1e9110d7f5f738bc3..29ee9311266ac4c82f0d59a469243705eca99abf 100644
--- a/device/usb/mock_usb_device.cc
+++ b/device/usb/mock_usb_device.cc
@@ -16,8 +16,13 @@ MockUsbDevice::MockUsbDevice(uint16_t vendor_id,
const std::string& manufacturer_string,
const std::string& product_string,
const std::string& serial_number)
- : UsbDevice(vendor_id,
+ : UsbDevice(0x0200,
+ 0xff,
+ 0xff,
+ 0xff,
asargent_no_longer_on_chrome 2016/04/04 23:52:28 optional: consider adding comments with the field
+ vendor_id,
product_id,
+ 0x0100,
base::UTF8ToUTF16(manufacturer_string),
base::UTF8ToUTF16(product_string),
base::UTF8ToUTF16(serial_number)) {}
@@ -28,8 +33,13 @@ MockUsbDevice::MockUsbDevice(uint16_t vendor_id,
const std::string& product_string,
const std::string& serial_number,
const GURL& webusb_landing_page)
- : UsbDevice(vendor_id,
+ : UsbDevice(0x0200,
+ 0xff,
+ 0xff,
+ 0xff,
+ vendor_id,
product_id,
+ 0x0100,
base::UTF8ToUTF16(manufacturer_string),
base::UTF8ToUTF16(product_string),
base::UTF8ToUTF16(serial_number)) {
« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | device/usb/mojo/type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698