Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: content/browser/renderer_host/java/java_bound_object.h

Issue 18570003: Move Renderer-side NPObject owner tracking to JavaBridgeChannel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move some comment cleanup to crrev.com/17428003 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/java/java_bound_object.h
diff --git a/content/browser/renderer_host/java/java_bound_object.h b/content/browser/renderer_host/java/java_bound_object.h
index ff97fdb2b6c379178ad9f5a2267e91e084f97d29..8891317b6de933ded1369431ab1769892a00195f 100644
--- a/content/browser/renderer_host/java/java_bound_object.h
+++ b/content/browser/renderer_host/java/java_bound_object.h
@@ -34,9 +34,10 @@ class JavaBoundObject {
// JavascriptInterface annotation are exposed to JavaScript. This property
// propagates to all Objects that get implicitly exposed as return values as
// well. Returns an NPObject with a ref count of one which owns the
- // JavaBoundObject.
+ // JavaBoundObject. The object is marked as owned by |owner|.
// See also comment below for |manager_|.
static NPObject* Create(
+ struct _NPP* owner,
joth 2013/07/02 20:49:03 I thought in C++ it's fine to just declare this as
Wez 2013/07/02 21:05:09 Yes. However, the NPAPI headers typedef struct _NP
const base::android::JavaRef<jobject>& object,
const base::android::JavaRef<jclass>& safe_annotation_clazz,
const base::WeakPtr<JavaBridgeDispatcherHostManager>& manager);
« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/renderer_host/java/java_bound_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698