Move Renderer-side NPObject owner tracking to JavaBridgeChannel.

Move Renderer-side NPObject owner tracking to JavaBridgeChannel.

This is defensive against the possibility of a single JavaBridgeChannel to the Browser hosting multiple JavaBridgeDispatchers.

BUG=152006
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210343

[Wez, 2013-07-02 20:27:14]

joth, jamesr: Can one of you review this, please?

[joth, 2013-07-02 20:49:03]

lgtm

https://codereview.chromium.org/18570003/diff/4001/content/browser/renderer_h...
File content/browser/renderer_host/java/java_bound_object.h (right):

https://codereview.chromium.org/18570003/diff/4001/content/browser/renderer_h...
content/browser/renderer_host/java/java_bound_object.h:40: struct _NPP* owner,
I thought in C++ it's fine to just declare this as "_NPP* owner" no 'struct'
needed, and chrome convention is to do it that way? (I have no strong opinion on
it though)

[Wez, 2013-07-02 21:05:08]

Thanks!

https://codereview.chromium.org/18570003/diff/4001/content/browser/renderer_h...
File content/browser/renderer_host/java/java_bound_object.h (right):

https://codereview.chromium.org/18570003/diff/4001/content/browser/renderer_h...
content/browser/renderer_host/java/java_bound_object.h:40: struct _NPP* owner,
On 2013/07/02 20:49:03, joth wrote:
> I thought in C++ it's fine to just declare this as "_NPP* owner" no 'struct'
> needed, and chrome convention is to do it that way? (I have no strong opinion
on
> it though)

Yes. However, the NPAPI headers typedef struct _NPP to NPP, so we've used struct
_NPP for consistency.

[Wez, 2013-07-02 21:05:22]

Thanks!

[Wez, 2013-07-02 21:05:22]

Thanks!

[commit-bot: I haz the power, 2013-07-02 21:19:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/18570003/4001

[commit-bot: I haz the power, 2013-07-03 06:45:13]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Wez, 2013-07-05 18:53:32]

FYI, I've split the Renderer and Browser side of this CL out, to make test
failures easier to track down.  Browser-side changes are now in
crrev.com/18378003 - will TBR that to you, joth@, since you've already reviewed
this CL.

[commit-bot: I haz the power, 2013-07-05 18:53:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/18570003/38001

[commit-bot: I haz the power, 2013-07-05 19:00:21]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-07-06 03:08:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/18570003/38001

[commit-bot: I haz the power, 2013-07-08 04:29:43]

Change committed as 210343