Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1856993004: Let mapToVisualRectInAncestorSpace apply ancestor clip if not scrollsOverflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Saturated
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index 1b1cb84d85e8dccfd2e7f7dd08e3193ef42541b0..73beb766aeed2e9537a064bb43a269329f185abf 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -49,6 +49,11 @@ enum ScrollOffsetClamping {
ScrollOffsetClamped
};
+enum ApplyOverflowClipFlag {
+ ApplyOverflowClip,
+ ApplyNonScrollOverflowClip
+};
+
struct LayoutBoxRareData {
WTF_MAKE_NONCOPYABLE(LayoutBoxRareData); USING_FAST_MALLOC(LayoutBoxRareData);
public:
@@ -835,12 +840,12 @@ public:
virtual bool needsPreferredWidthsRecalculation() const;
IntSize scrolledContentOffset() const;
- void mapScrollingContentsRectToBoxSpace(LayoutRect&) const;
- // Returns true if the rect actually intersects the clipping region.
+ // Maps a rect in scrolling contents space to box space and apply overflow clip if needed.
+ // Returns true if no clipping applied or the rect actually intersects the clipping region.
// If edgeInclusive is true, then this method may return true even
// if the resulting rect has zero area.
- bool applyOverflowClip(LayoutRect&, VisualRectFlags = DefaultVisualRectFlags) const;
+ bool mapScrollingContentsRectToBoxSpace(LayoutRect&, ApplyOverflowClipFlag, VisualRectFlags = DefaultVisualRectFlags) const;
virtual bool hasRelativeLogicalWidth() const;
virtual bool hasRelativeLogicalHeight() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698