Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1856993004: Let mapToVisualRectInAncestorSpace apply ancestor clip if not scrollsOverflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Saturated
Patch Set: Use the same clip policy for slow path and fast path Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 9655aac8a07ee74ede97abbb5aa82cc18d1b38e5..b8c19d92a1701b8c25e2559f749f9d8a6cc2b8ea 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -1989,8 +1989,10 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances
if (container->hasOverflowClip()) {
LayoutBox* containerBox = toLayoutBox(container);
containerBox->mapScrollingContentsRectToBoxSpace(rect);
- if (container != ancestor && !containerBox->applyOverflowClip(rect, visualRectFlags))
- return false;
+ if (container != ancestor || !containerBox->scrollsOverflow()) {
pdr. 2016/04/07 18:23:45 This block (check hasOverflowClip , mapScrollingCo
Xianzhu 2016/04/07 19:04:50 Done.
+ if (!containerBox->applyOverflowClip(rect, visualRectFlags))
+ return false;
+ }
}
if (ancestorSkipped) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698