Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1856923002: MD Settings: Certificate manager, remove border from last certificate entry. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Certificate manager, remove border from last certificate entry. BUG=595768 Committed: https://crrev.com/9385c702c38d0150f843b7ed3403d9458d3b51dd Cr-Commit-Position: refs/heads/master@{#385089}

Patch Set 1 #

Patch Set 2 : Use more CSS, less JS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_entry.js View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dpapad
This is addressing the problem shown at https://bugs.chromium.org/p/chromium/issues/detail?id=595768#c16 (see screenshot).
4 years, 8 months ago (2016-04-04 19:42:58 UTC) #2
dschuyler
Thanks for second patch! LGTM
4 years, 8 months ago (2016-04-05 01:21:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856923002/20001
4 years, 8 months ago (2016-04-05 01:29:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 02:21:30 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 02:23:01 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9385c702c38d0150f843b7ed3403d9458d3b51dd
Cr-Commit-Position: refs/heads/master@{#385089}

Powered by Google App Engine
This is Rietveld 408576698