Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/resources/settings/languages_page/manage_languages_page.js

Issue 1856873002: MD Settings: Polish languages pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LanguageStyleToHtml
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/manage_languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/manage_languages_page.js b/chrome/browser/resources/settings/languages_page/manage_languages_page.js
index a806b201038276aad815487d98873d0765181994..c7e44bfad36a6171ca2bff9f3b3fbda6c7c7a13a 100644
--- a/chrome/browser/resources/settings/languages_page/manage_languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/manage_languages_page.js
@@ -51,16 +51,22 @@ Polymer({
},
/**
- * Handler for adding a language.
- * @param {!{model: {item: !chrome.languageSettingsPrivate.Language}}} e
+ * Handler for checking or unchecking a language item.
+ * @param {!{model: !{item: !chrome.languageSettingsPrivate.Language},
+ * target: !PaperCheckboxElement}} e
* @private
*/
- onAddLanguageTap_: function(e) {
- this.languageHelper_.enableLanguage(e.model.item.code);
+ onLanguageCheckboxChange_: function(e) {
+ var code = e.model.item.code;
+ if (e.target.checked)
+ this.languageHelper_.enableLanguage(code);
+ else
+ this.languageHelper_.disableLanguage(code);
},
/**
- * True if a language is not the current or prospective UI language.
+ * True if a language is not the current or prospective UI language, ie,
+ * it could be disabled.
* @param {string} languageCode
* @param {string} prospectiveUILanguageCode
* @return {boolean}
@@ -71,7 +77,6 @@ Polymer({
languageCode == prospectiveUILanguageCode) {
return false;
}
- assert(this.languages.enabledLanguages.length > 1);
return true;
},

Powered by Google App Engine
This is Rietveld 408576698