Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1856843002: Reland of Propagate is_official_build to version script. (Closed)

Created:
4 years, 8 months ago by Peter Wen
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, agrieve, Sami
CC:
chromium-reviews, jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1851843002/ ) Reason for revert: The actual crash was in OmahaClient, which is fixed in: http://crrev.com/1856823002 Original issue's description: > Revert of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1838173005/ ) > > Reason for revert: > Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830 > > Original issue's description: > > Propagate is_official_build to version script. > > > > OFFICIAL_BUILD is a special variable in the version script which > > takes its value from the environment variable. This means that local > > builds with is_official_build will not actually result in > > ChromeVersionConstants.isOfficialBuild() returning true. > > > > This CL propagates the is_official_build truthiness to the script so > > official builds no longer depend solely on the environment variable. > > > > BUG=599268 > > > > Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9 > > Cr-Commit-Position: refs/heads/master@{#384340} > > TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=599268 > > Committed: https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b > Cr-Commit-Position: refs/heads/master@{#384610} TBR=agrieve@chromium.org,thestig@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=599268 Committed: https://crrev.com/87d01a7e475b0785364328af5b22b15b28a40e66 Cr-Commit-Position: refs/heads/master@{#385007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/util/version.py View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/version.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Peter Wen
Created Reland of Propagate is_official_build to version script.
4 years, 8 months ago (2016-04-04 17:26:46 UTC) #1
agrieve
On 2016/04/04 17:26:46, Peter Wen wrote: > Created Reland of Propagate is_official_build to version script. ...
4 years, 8 months ago (2016-04-04 19:15:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856843002/1
4 years, 8 months ago (2016-04-04 19:48:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 21:15:48 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 21:17:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87d01a7e475b0785364328af5b22b15b28a40e66
Cr-Commit-Position: refs/heads/master@{#385007}

Powered by Google App Engine
This is Rietveld 408576698