DescriptionReland of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1851843002/ )
Reason for revert:
The actual crash was in OmahaClient, which is fixed in: http://crrev.com/1856823002
Original issue's description:
> Revert of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1838173005/ )
>
> Reason for revert:
> Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830
>
> Original issue's description:
> > Propagate is_official_build to version script.
> >
> > OFFICIAL_BUILD is a special variable in the version script which
> > takes its value from the environment variable. This means that local
> > builds with is_official_build will not actually result in
> > ChromeVersionConstants.isOfficialBuild() returning true.
> >
> > This CL propagates the is_official_build truthiness to the script so
> > official builds no longer depend solely on the environment variable.
> >
> > BUG=599268
> >
> > Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
> > Cr-Commit-Position: refs/heads/master@{#384340}
>
> TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=599268
>
> Committed: https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b
> Cr-Commit-Position: refs/heads/master@{#384610}
TBR=agrieve@chromium.org,thestig@chromium.org,skyostil@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599268
Committed: https://crrev.com/87d01a7e475b0785364328af5b22b15b28a40e66
Cr-Commit-Position: refs/heads/master@{#385007}
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|