Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 185683008: DevTools: Fix live-edit.html test. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix live-edit.html test. The failure happened because live-edit-no-reveal.html live edited the same script and this somehow interfered with live-edit.html execution. BUG=282082 TBR=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168609

Patch Set 1 #

Patch Set 2 : Added new file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit-no-reveal.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/resources/edit-me-when-paused-no-reveal.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-06 07:42:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/185683008/20001
6 years, 9 months ago (2014-03-06 07:42:15 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 09:29:56 UTC) #3
Message was sent while issue was closed.
Change committed as 168609

Powered by Google App Engine
This is Rietveld 408576698