Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 185683003: Draw a single underline for text-decoration-style: [dashed, dotted]. (Closed)

Created:
6 years, 9 months ago by andersr
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jbroman, danakj, Rik, jchaffraix+rendering, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Draw a single underline for text-decoration-style: [dashed, dotted]. There is a bug in the new text-decoration styles where the dashed and dotted underlines would be drawn twice. This appears to be because we are stroking a SkRect of height zero. Fixed by drawing a line rather than stroking a rect. BUG=348518 TEST=Covered by existing tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168743

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased + resolved conflicts with GraphicsContext.cpp #

Patch Set 3 : Add missing switch case, which caused compilation failure. #

Patch Set 4 : Rebased (no conflicts) #

Patch Set 5 : Don't modify rendering behavior of old decorations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 2 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
andersr
6 years, 9 months ago (2014-03-03 14:14:34 UTC) #1
andersr
Like I mentioned to abinader on IRC, I have two thoughts regarding this patch: 1) ...
6 years, 9 months ago (2014-03-05 14:55:18 UTC) #2
Stephen Chennney
This change LGTM. Regarding the dashing, the GraphicsContext implementation tries to ensure that there is ...
6 years, 9 months ago (2014-03-05 15:59:34 UTC) #3
Stephen Chennney
On 2014/03/05 14:55:18, andersr wrote: > 1) Should I do something with RenderBoxModelObject::shouldAntialiasLines? > Perhaps ...
6 years, 9 months ago (2014-03-05 16:03:26 UTC) #4
andersr
The CQ bit was checked by andersr@opera.com
6 years, 9 months ago (2014-03-05 19:45:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/185683003/1
6 years, 9 months ago (2014-03-05 19:47:19 UTC) #6
andersr
The CQ bit was unchecked by andersr@opera.com
6 years, 9 months ago (2014-03-05 20:43:07 UTC) #7
Stephen Chennney
I now see why I was wrong about it always being possible to start/end any ...
6 years, 9 months ago (2014-03-06 00:50:07 UTC) #8
andersr
The CQ bit was checked by andersr@opera.com
6 years, 9 months ago (2014-03-06 12:13:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/185683003/30001
6 years, 9 months ago (2014-03-06 12:13:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 12:49:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-06 12:49:01 UTC) #12
Stephen Chennney
The CQ bit was checked by schenney@chromium.org
6 years, 9 months ago (2014-03-06 21:21:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/185683003/30001
6 years, 9 months ago (2014-03-06 21:21:26 UTC) #14
Stephen Chennney
I think this will fail to apply so you might need to rebase.
6 years, 9 months ago (2014-03-06 21:25:05 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 22:06:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-06 22:07:00 UTC) #17
andersr
> I think this will fail to apply so you might need to rebase. Rebased ...
6 years, 9 months ago (2014-03-07 09:24:08 UTC) #18
andersr
The CQ bit was checked by andersr@opera.com
6 years, 9 months ago (2014-03-07 13:54:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/185683003/60005
6 years, 9 months ago (2014-03-07 13:54:31 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 14:11:53 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-07 14:11:53 UTC) #22
andersr
The CQ bit was checked by andersr@opera.com
6 years, 9 months ago (2014-03-07 14:46:24 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/185683003/60005
6 years, 9 months ago (2014-03-07 14:47:00 UTC) #24
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 15:49:31 UTC) #25
Message was sent while issue was closed.
Change committed as 168743

Powered by Google App Engine
This is Rietveld 408576698