Add null-check in OmahaClient for handling intent.

Add null-check in OmahaClient for handling intent.

Since getRequestGenerator() is used without null guards in all
subsequent calls, it should be verified before making those calls.

This check will be extremely quick if ChromeApplication returns null,
and it will only incur a one-time cost otherwise, and this is not on
the UI thread, so it should have minimal performance impact.

BUG=584114
Committed: https://crrev.com/85705c2257f562b092c8d04996683439e43ce76f
Cr-Commit-Position: refs/heads/master@{#384955}

[Peter Wen, 2016-04-04 16:31:51]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2016-04-04 16:31:52]

🚀

[gone, 2016-04-04 17:06:45]

lgtm

https://codereview.chromium.org/1856823002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java
(right):

https://codereview.chromium.org/1856823002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java:205:
if (getRequestGenerator() == null) {
I'd actually move this above mStateHasBeenRestored to prevent it from doing
unnecessary restoration, but it is fine here, I think.

[Peter Wen, 2016-04-04 17:25:42]

Thanks for the quick review! :)

https://codereview.chromium.org/1856823002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java
(right):

https://codereview.chromium.org/1856823002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java:205:
if (getRequestGenerator() == null) {
On 2016/04/04 17:06:45, dfalcantara wrote:
> I'd actually move this above mStateHasBeenRestored to prevent it from doing
> unnecessary restoration, but it is fine here, I think.

Done.

[Peter Wen, 2016-04-04 17:25:48]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-04-04 17:25:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1856823002/#ps20001
(title: "Move check earlier.")

[commit-bot: I haz the power, 2016-04-04 17:26:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1856823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1856823002/20001

[commit-bot: I haz the power, 2016-04-04 18:09:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-04 18:10:11]

Description was changed from

==========
Add null-check in OmahaClient for handling intent.

Since getRequestGenerator() is used without null guards in all
subsequent calls, it should be verified before making those calls.

This check will be extremely quick if ChromeApplication returns null,
and it will only incur a one-time cost otherwise, and this is not on
the UI thread, so it should have minimal performance impact.

BUG=584114
==========

to

==========
Add null-check in OmahaClient for handling intent.

Since getRequestGenerator() is used without null guards in all
subsequent calls, it should be verified before making those calls.

This check will be extremely quick if ChromeApplication returns null,
and it will only incur a one-time cost otherwise, and this is not on
the UI thread, so it should have minimal performance impact.

BUG=584114

Committed: https://crrev.com/85705c2257f562b092c8d04996683439e43ce76f
Cr-Commit-Position: refs/heads/master@{#384955}
==========

[commit-bot: I haz the power, 2016-04-04 18:10:12]

Patchset 2 (id:??) landed as
https://crrev.com/85705c2257f562b092c8d04996683439e43ce76f
Cr-Commit-Position: refs/heads/master@{#384955}