Turn infer types into proper HPhase.

Turn infer types into proper HPhase.

R=dslomov@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15535

[Dmitry Lomov (no reviews), 2013-07-08 08:18:50]

https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h
File src/hydrogen-infer-types.h (right):

https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h#ne...
src/hydrogen-infer-types.h:48: void InitializeInferredTypes(int from_inclusive,
int to_inclusive);
InitializeInferredTypes is misleading, since this is actually the method that
does all the work. Let's remove this method and do all the work directly in Run.

https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h#ne...
src/hydrogen-infer-types.h:50: ZoneList<HValue*> worklist_;
worklist_ and in_worklist_ are now local to InitializeInferredTypes, so these
fields are not needed.

[Benedikt Meurer, 2013-07-08 08:22:33]

https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h
File src/hydrogen-infer-types.h (right):

https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h#ne...
src/hydrogen-infer-types.h:48: void InitializeInferredTypes(int from_inclusive,
int to_inclusive);
On 2013/07/08 08:18:50, Dmitry Lomov (chromium) wrote:
> InitializeInferredTypes is misleading, since this is actually the method that
> does all the work. Let's remove this method and do all the work directly in
Run.

We need the separate method for the recursive calls.

[Dmitry Lomov (no reviews), 2013-07-08 08:25:19]

On 2013/07/08 08:22:33, Benedikt Meurer wrote:
> https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h
> File src/hydrogen-infer-types.h (right):
> 
>
https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h#ne...
> src/hydrogen-infer-types.h:48: void InitializeInferredTypes(int
from_inclusive,
> int to_inclusive);
> On 2013/07/08 08:18:50, Dmitry Lomov (chromium) wrote:
> > InitializeInferredTypes is misleading, since this is actually the method
that
> > does all the work. Let's remove this method and do all the work directly in
> Run.
> 
> We need the separate method for the recursive calls.

Ah ok got it, then the comment about fields does not apply too. 
Maybe consider renaming InitializeInferredTypes -> InferTypes, but otherwise
lgtm.

[Benedikt Meurer, 2013-07-08 08:32:48]

>
https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h#ne...
> > src/hydrogen-infer-types.h:48: void InitializeInferredTypes(int
> from_inclusive,
> > int to_inclusive);
> > > InitializeInferredTypes is misleading, since this is actually the method
> that
> > > does all the work. Let's remove this method and do all the work directly
in
> > Run.
> > 
> > We need the separate method for the recursive calls.
> 
> Ah ok got it, then the comment about fields does not apply too. 
> Maybe consider renaming InitializeInferredTypes -> InferTypes, but otherwise
> lgtm.

Done.

[Benedikt Meurer, 2013-07-08 08:33:16]

Committed patchset #3 manually as r15535 (presubmit successful).