Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1856793002: Revert of WTF::ThreadSpecific should use base::ThreadLocalStorage. (Closed)

Created:
4 years, 8 months ago by esprehn
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, kinuko+watch, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WTF::ThreadSpecific should use base::ThreadLocalStorage. (patchset #4 id:60001 of https://codereview.chromium.org/1849023002/ ) Reason for revert: May have caused a bunch of perf regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=600271 Original issue's description: > WTF::ThreadSpecific should use base::ThreadLocalStorage. > > Let's use the base abstraction to allocate the > TLS. It's way less code. > > Committed: https://crrev.com/56641fdb889c6b5d27997465b622d7432c0ba0b8 > Cr-Commit-Position: refs/heads/master@{#384650} TBR=danakj@chromium.org,haraken@chromium.org,yutak@chromium.org NOTRY=true Committed: https://crrev.com/4566bb7bf4a2c0d56474cd0b9e2f131df11d331d Cr-Commit-Position: refs/heads/master@{#385013}

Patch Set 1 #

Patch Set 2 : Manual revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -35 lines) Patch
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 1 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSpecific.h View 1 1 chunk +217 lines, -31 lines 0 comments Download
A third_party/WebKit/Source/wtf/ThreadSpecificWin.cpp View 1 1 chunk +137 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
esprehn
Created Revert of WTF::ThreadSpecific should use base::ThreadLocalStorage.
4 years, 8 months ago (2016-04-04 15:19:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856793002/1
4 years, 8 months ago (2016-04-04 15:19:33 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/13303) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-04 15:21:49 UTC) #4
esprehn
Heh seems auto revert can't revet something that removes a file? :/
4 years, 8 months ago (2016-04-04 15:28:22 UTC) #5
haraken
LGTM to revert.
4 years, 8 months ago (2016-04-04 15:43:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856793002/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856793002/170001
4 years, 8 months ago (2016-04-04 19:27:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856793002/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856793002/170001
4 years, 8 months ago (2016-04-04 21:33:03 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:170001)
4 years, 8 months ago (2016-04-04 21:38:47 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4566bb7bf4a2c0d56474cd0b9e2f131df11d331d Cr-Commit-Position: refs/heads/master@{#385013}
4 years, 8 months ago (2016-04-04 21:40:05 UTC) #16
esprehn
4 years, 8 months ago (2016-04-04 23:48:03 UTC) #17
Message was sent while issue was closed.
Woops forgot BUG=,

See https://bugs.chromium.org/p/chromium/issues/detail?id=600271

Powered by Google App Engine
This is Rietveld 408576698