Provide an explicit 2nd parameter to historyView.showNotification()

Provide an explicit 2nd parameter to historyView.showNotification()

HistoryView.prototype.showNotification() requires two parameters,
but the callsite in HistoryView.prototype.showWebHistoryNotification,
added in https://codereview.chromium.org/1838333004/, only passes one.

This is functionally equivalent, since the second parameter should be
"false". However, this shows as an error on the Closure compiler.

TBR=dbeam@chromium.org,jyquinn@chromium.org,sky@chromium.org
BUG=595332
Committed: https://crrev.com/7b1d959bc4e1cae64abdeff2c5baeb9c38c3813b
Cr-Commit-Position: refs/heads/master@{#384918}

[msramek, 2016-04-04 15:06:41]

Hi folks,

https://codereview.chromium.org/1838333004/ which I just landed caused an error
on one of the FYI bots, so I'm just landing this quick fix. It's tiny, so I'll
leave this CL as TBR.

Martin

[msramek, 2016-04-04 15:06:54]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-04-04 15:07:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1856773002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1856773002/1

[commit-bot: I haz the power, 2016-04-04 15:55:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-04 15:56:22]

Description was changed from

==========
Provide an explicit 2nd parameter to historyView.showNotification()

HistoryView.prototype.showNotification() requires two parameters,
but the callsite in HistoryView.prototype.showWebHistoryNotification,
added in https://codereview.chromium.org/1838333004/, only passes one.

This is functionally equivalent, since the second parameter should be
"false". However, this shows as an error on the Closure compiler.

TBR=dbeam@chromium.org,jyquinn@chromium.org,sky@chromium.org
BUG=595332
==========

to

==========
Provide an explicit 2nd parameter to historyView.showNotification()

HistoryView.prototype.showNotification() requires two parameters,
but the callsite in HistoryView.prototype.showWebHistoryNotification,
added in https://codereview.chromium.org/1838333004/, only passes one.

This is functionally equivalent, since the second parameter should be
"false". However, this shows as an error on the Closure compiler.

TBR=dbeam@chromium.org,jyquinn@chromium.org,sky@chromium.org
BUG=595332

Committed: https://crrev.com/7b1d959bc4e1cae64abdeff2c5baeb9c38c3813b
Cr-Commit-Position: refs/heads/master@{#384918}
==========

[commit-bot: I haz the power, 2016-04-04 15:56:23]

Patchset 1 (id:??) landed as
https://crrev.com/7b1d959bc4e1cae64abdeff2c5baeb9c38c3813b
Cr-Commit-Position: refs/heads/master@{#384918}

[Dan Beam, 2016-04-04 18:47:18]

lgtm

fyi: i think this was the right call but there's also the ability to annotate
something as an optional parameter, as in:

  /** @param {boolean=} opt_isWarning */

where the = in the type means |undefined (and doesn't warn when omitted from
callsites) and the opt_ prefix tells the reader it's optional.