Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3429)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java

Issue 1856753002: GCM: Fix for null Sender ID on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove @Nullable Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java b/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java
index 2104cf3967d79681ed0fe2274848020f2738f718..64ab0f58b516e134126c3e4ab3f72b35ecaeaf74 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java
@@ -28,7 +28,7 @@ public class ChromeGcmListenerService extends GcmListenerService {
AndroidGcmController.get(this).onMessageReceived(data);
return;
}
- pushMessageReceived(data);
+ pushMessageReceived(from, data);
}
@Override
@@ -50,7 +50,7 @@ public class ChromeGcmListenerService extends GcmListenerService {
+ "know what subtype (app ID) it occurred for.");
}
- private void pushMessageReceived(final Bundle data) {
+ private void pushMessageReceived(final String from, final Bundle data) {
final String bundleSubtype = "subtype";
if (!data.containsKey(bundleSubtype)) {
Log.w(TAG, "Received push message with no subtype");
@@ -62,7 +62,7 @@ public class ChromeGcmListenerService extends GcmListenerService {
public void run() {
PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX,
getApplicationContext());
- GCMDriver.onMessageReceived(getApplicationContext(), appId, data);
+ GCMDriver.onMessageReceived(getApplicationContext(), appId, from, data);
}
});
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698