Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 185673002: Oilpan: ~CSSGroupingRule should not touch its Member<>. (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Oilpan: ~CSSGroupingRule should not touch its Member<>. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/css/CSSGroupingRule.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kouhei (in TOK)
PTAL.
6 years, 9 months ago (2014-03-03 06:30:46 UTC) #1
haraken
LGTM. This kind of error will be caught by ASAN once we enable ASAN in ...
6 years, 9 months ago (2014-03-03 06:33:51 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-03 06:36:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/185673002/1
6 years, 9 months ago (2014-03-03 06:37:05 UTC) #4
Mads Ager (chromium)
LGTM!
6 years, 9 months ago (2014-03-03 07:31:20 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 08:22:30 UTC) #6
Message was sent while issue was closed.
Change committed as 168277

Powered by Google App Engine
This is Rietveld 408576698