Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1856683003: Address comments from https://codereview.chromium.org/1852143002 (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
joedow
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address comments from https://codereview.chromium.org/1852143002 BUG= Committed: https://crrev.com/a27a40de379c0c36ef41f623150c600591b6da58 Cr-Commit-Position: refs/heads/master@{#384926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/win/current_module.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 8 months ago (2016-04-04 15:43:23 UTC) #2
joedow
lgtm
4 years, 8 months ago (2016-04-04 15:45:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856683003/1
4 years, 8 months ago (2016-04-04 15:46:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 16:34:46 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 16:36:12 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a27a40de379c0c36ef41f623150c600591b6da58
Cr-Commit-Position: refs/heads/master@{#384926}

Powered by Google App Engine
This is Rietveld 408576698