Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1856683002: Fix resuming generator marked for optimization. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix resuming generator marked for optimization. This fixes a corner case where the generator function of a suspended generator has been marked for optimization. We assume the optimization approach will cause a bailout because generators are not optimized. But resuming is more resilient by always activating the unoptimized code. R=neis@chromium.org,bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-513471 BUG=chromium:513471 LOG=n Committed: https://crrev.com/6ab9c1850f7b2c1225d63286c14d0b54687c5515 Cr-Commit-Position: refs/heads/master@{#35234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/runtime/runtime-generator.cc View 2 chunks +8 lines, -6 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-513471.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Michael Starzinger
Georg: PTAL. Benedikt: You'll probably need to rebase your change.
4 years, 8 months ago (2016-04-04 11:24:02 UTC) #1
neis
lgtm, thanks
4 years, 8 months ago (2016-04-04 11:26:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856683002/1
4 years, 8 months ago (2016-04-04 11:45:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13175)
4 years, 8 months ago (2016-04-04 11:49:01 UTC) #6
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-04 11:49:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856683002/1
4 years, 8 months ago (2016-04-04 11:49:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 11:51:54 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6ab9c1850f7b2c1225d63286c14d0b54687c5515 Cr-Commit-Position: refs/heads/master@{#35234}
4 years, 8 months ago (2016-04-04 11:52:17 UTC) #14
Michael Achenbach
Please skip or mark as fail for win nosnap & Ignition: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/12681
4 years, 8 months ago (2016-04-04 13:37:49 UTC) #16
Michael Starzinger
4 years, 8 months ago (2016-04-04 14:26:30 UTC) #17
Message was sent while issue was closed.
On 2016/04/04 13:37:49, Michael Achenbach (OOO) wrote:
> Please skip or mark as fail for win nosnap & Ignition:
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%2...

Thanks! Doing so in follow-up CL: https://codereview.chromium.org/1859523003/

Powered by Google App Engine
This is Rietveld 408576698