Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1856653002: Properly complete in-object slack tracking. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly complete in-object slack tracking. BUG=chromium:599003 LOG=N Committed: https://crrev.com/4598356f1723da448daf0aee98610c85f754f6ce Cr-Commit-Position: refs/heads/master@{#35232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M src/objects.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-599003.js View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856653002/1
4 years, 8 months ago (2016-04-04 08:20:42 UTC) #3
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-04 08:20:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 08:42:48 UTC) #7
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-04 09:58:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856653002/1
4 years, 8 months ago (2016-04-04 09:58:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 10:00:34 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 10:00:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4598356f1723da448daf0aee98610c85f754f6ce
Cr-Commit-Position: refs/heads/master@{#35232}

Powered by Google App Engine
This is Rietveld 408576698