Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1856633002: Support nested calc() (Closed)

Created:
4 years, 8 months ago by Timothy Loh
Modified:
4 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support nested calc() This patch adds support for nested calc(). This just means that where we allow a left parenthesis we also allow using calc(. Nested calc() can be useful when using variables as it allows variables to be used inside calc() expressions more freely. FF added support for nested calc() a couple of weeks ago. While we support -webkit-calc(), we don't add nesting support for it. BUG=600113 https://drafts.csswg.org/css-values/#calc-syntax https://bugzilla.mozilla.org/show_bug.cgi?id=968761 Committed: https://crrev.com/08d6e889c5efdf7d93e0badcd1cd5dcb8e79574c Cr-Commit-Position: refs/heads/master@{#385076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/css3/calc/calc-nesting.html View 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
4 years, 8 months ago (2016-04-04 02:09:39 UTC) #2
nainar
lgtm
4 years, 8 months ago (2016-04-04 04:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856633002/1
4 years, 8 months ago (2016-04-05 01:28:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 01:35:04 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 01:36:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08d6e889c5efdf7d93e0badcd1cd5dcb8e79574c
Cr-Commit-Position: refs/heads/master@{#385076}

Powered by Google App Engine
This is Rietveld 408576698